Clean Code for ds/org.eclipse.pde.ds.tck

[eclipse-pde-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

The following Manifest cleanups where applied:

• Calculate 'uses' directive for public packages
• Remove unused dependencies

[eclipse-eca-validation]

Hi @eclipse-pde-bot — thank you for your contribution!

The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:

• An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(committer).
• An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(author).

To resolve this, please:

1. Sign in or create an Eclipse Foundation account: https://accounts.eclipse.org/user/eca
2. Ensure your GitHub username is linked to your Eclipse account
3. Complete and submit the ECA form

Once done, push a new commit (or rebase) to re-trigger the ECA validation.

If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk.

Thanks again for your contribution!

[github-actions]

Test Results

  126 files  ±0    126 suites  ±0   37m 32s ⏱️ +19s
3 502 tests ±0  3 448 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 321 runs  ±0  9 191 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit 5d5de3d. ± Comparison against base commit 0ca2373.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

Cleans up the org.eclipse.pde.ds.tck bundle metadata as part of broader formatting/dependency hygiene for the DS TCK project.

Changes:

• Removes the Import-Package header from the DS TCK bundle manifest.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Removing the Import-Package header entirely means this bundle will not be wired to any org.osgi.* packages at runtime. Since this project unpacks and builds the OSGi DS annotations TCK sources during the Maven build (see pom.xml unpack-dependencies + PDE build), the compiled classes are very likely to reference org.osgi.framework / DS / Log APIs and will fail with ClassNotFoundException at runtime if these packages are not imported. Please restore the required Import-Package entries (or switch to an automated manifest generation approach that computes them from the built classes) so the bundle resolves its API dependencies correctly.