Skip to content

Clean Code for ds/org.eclipse.pde.ds.tck #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eclipse-pde-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean Code for ds/org.eclipse.pde.ds.tck #2178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ds/org.eclipse.pde.ds.tck/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ Bundle-ManifestVersion: 2
Bundle-Name: Component XML TCK
Bundle-SymbolicName: org.eclipse.pde.ds.tck
Bundle-Version: 1.0.0.qualifier
Import-Package: org.osgi.framework,
org.osgi.service.component,
org.osgi.service.component.propertytypes,
org.osgi.service.log
Service-Component: OSGI-INF/org.osgi.impl.bundle.component.annotations.HelloWorld10.xml,
Comment on lines 5 to 6
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Import-Package header entirely means this bundle will not be wired to any org.osgi.* packages at runtime. Since this project unpacks and builds the OSGi DS annotations TCK sources during the Maven build (see pom.xml unpack-dependencies + PDE build), the compiled classes are very likely to reference org.osgi.framework / DS / Log APIs and will fail with ClassNotFoundException at runtime if these packages are not imported. Please restore the required Import-Package entries (or switch to an automated manifest generation approach that computes them from the built classes) so the bundle resolves its API dependencies correctly.

Copilot uses AI. Check for mistakes.
OSGI-INF/testActivationFields.xml,
OSGI-INF/testComponentPropertyTypes.xml,
Expand Down
Loading