Add support for model aifs-subs and aifs-subs-crps#179
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for additional AIFS model identifiers in the metkit MARS→GRIB pipeline by extending the background-process table mapping and exposing the new model names in the metkit language schema.
Changes:
- Extends
BackgroundProcessenum and string↔enum mappings to includeaifs-subsandaifs-subs-crps. - Updates the set of allowed
modelvalues inshare/metkit/language.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/metkit/mars2grib/backend/tables/backgroundProcess.h |
Adds new background-process enum values and updates the mapping functions/documentation. |
share/metkit/language.yaml |
Allows aifs-subs and aifs-subs-crps as valid model values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #179 +/- ##
===========================================
+ Coverage 62.54% 62.61% +0.06%
===========================================
Files 303 303
Lines 11548 11554 +6
Branches 1029 1029
===========================================
+ Hits 7223 7234 +11
+ Misses 4325 4320 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
19df506 to
29ba485
Compare
tweska
left a comment
There was a problem hiding this comment.
Looks good to me, just need to run clang-format to make the CI happy. :^)
29ba485 to
1182924
Compare
1182924 to
838d1bc
Compare
Description
Contributor Declaration
By opening this pull request, I affirm the following: