Skip to content

Add support for model aifs-subs and aifs-subs-crps#179

Merged
dsarmany merged 1 commit intodevelopfrom
178-add-aifs-subs-to-encoder
Mar 13, 2026
Merged

Add support for model aifs-subs and aifs-subs-crps#179
dsarmany merged 1 commit intodevelopfrom
178-add-aifs-subs-to-encoder

Conversation

@dsarmany
Copy link
Copy Markdown
Contributor

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@dsarmany dsarmany requested review from Copilot, danovaro and tweska March 11, 2026 18:54
@dsarmany dsarmany linked an issue Mar 11, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for additional AIFS model identifiers in the metkit MARS→GRIB pipeline by extending the background-process table mapping and exposing the new model names in the metkit language schema.

Changes:

  • Extends BackgroundProcess enum and string↔enum mappings to include aifs-subs and aifs-subs-crps.
  • Updates the set of allowed model values in share/metkit/language.yaml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/metkit/mars2grib/backend/tables/backgroundProcess.h Adds new background-process enum values and updates the mapping functions/documentation.
share/metkit/language.yaml Allows aifs-subs and aifs-subs-crps as valid model values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI commented Mar 11, 2026

@dsarmany I've opened a new pull request, #180, to work on those changes. Once the pull request is ready, I'll request review from you.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.61%. Comparing base (e0c9b28) to head (838d1bc).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...etkit/mars2grib/backend/tables/backgroundProcess.h 20.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    62.54%   62.61%   +0.06%     
===========================================
  Files          303      303              
  Lines        11548    11554       +6     
  Branches      1029     1029              
===========================================
+ Hits          7223     7234      +11     
+ Misses        4325     4320       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsarmany dsarmany force-pushed the 178-add-aifs-subs-to-encoder branch 2 times, most recently from 19df506 to 29ba485 Compare March 12, 2026 09:07
Copy link
Copy Markdown
Member

@tweska tweska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to run clang-format to make the CI happy. :^)

@dsarmany dsarmany force-pushed the 178-add-aifs-subs-to-encoder branch from 29ba485 to 1182924 Compare March 13, 2026 10:28
@dsarmany dsarmany force-pushed the 178-add-aifs-subs-to-encoder branch from 1182924 to 838d1bc Compare March 13, 2026 16:54
@dsarmany dsarmany merged commit 838d1bc into develop Mar 13, 2026
66 checks passed
@dsarmany dsarmany deleted the 178-add-aifs-subs-to-encoder branch March 13, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aifs-subs to encoder

5 participants