Skip to content

Preserve existing GRIB codes when adding aifs-subs and aifs-subs-crps to BackgroundProcess enum#180

Merged
dsarmany merged 1 commit into178-add-aifs-subs-to-encoderfrom
copilot/sub-pr-179
Mar 11, 2026
Merged

Preserve existing GRIB codes when adding aifs-subs and aifs-subs-crps to BackgroundProcess enum#180
dsarmany merged 1 commit into178-add-aifs-subs-to-encoderfrom
copilot/sub-pr-179

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 11, 2026

Inserting aifs_subs and aifs_subs_crps into the middle of the BackgroundProcess enum shifted all subsequent numeric codes, silently changing the GRIB backgroundProcess values written for existing models and breaking compatibility with existing data and table definitions.

Changes

  • Restore original codes: Pre-existing enum values retain their original assignments (aifs_single_mse=3, aifs_ens_crps=4, aifs_ens_diff=5, aifs_compo_single=6, aifs_compo_ens=7, aifs_compo_single_mse=8, aifs_compo_ens_crps=9)
  • Allocate new codes for new entries: aifs_subs and aifs_subs_crps are assigned the next available unused codes (10 and 11)
enum class BackgroundProcess : long {
    aifs_single           = 1,
    aifs_ens              = 2,
    aifs_single_mse       = 3,  // restored
    aifs_ens_crps         = 4,  // restored
    aifs_ens_diff         = 5,  // restored
    aifs_compo_single     = 6,  // restored
    aifs_compo_ens        = 7,  // restored
    aifs_compo_single_mse = 8,  // restored
    aifs_compo_ens_crps   = 9,  // restored
    aifs_subs             = 10, // new
    aifs_subs_crps        = 11, // new
    ifs                   = 255
};

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] [WIP] Address feedback on adding support for model aifs-subs and aifs-subs-crps Preserve existing GRIB codes when adding aifs-subs and aifs-subs-crps to BackgroundProcess enum Mar 11, 2026
Co-authored-by: dsarmany <66944306+dsarmany@users.noreply.github.com>
@dsarmany dsarmany force-pushed the copilot/sub-pr-179 branch from 9c02ec8 to cf997ef Compare March 11, 2026 21:49
@dsarmany dsarmany merged commit cf997ef into 178-add-aifs-subs-to-encoder Mar 11, 2026
65 checks passed
@dsarmany dsarmany deleted the copilot/sub-pr-179 branch March 11, 2026 21:50
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.46%. Comparing base (5aacfd4) to head (cf997ef).
⚠️ Report is 1 commits behind head on 178-add-aifs-subs-to-encoder.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           178-add-aifs-subs-to-encoder     #180   +/-   ##
=============================================================
  Coverage                         61.46%   61.46%           
=============================================================
  Files                               310      310           
  Lines                             11849    11849           
  Branches                           1040     1040           
=============================================================
  Hits                               7283     7283           
  Misses                             4566     4566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants