libdocker: fix empty container IP on Docker Desktop for macOS#1411
Open
qu0b wants to merge 1 commit intoethereum:masterfrom
Open
libdocker: fix empty container IP on Docker Desktop for macOS#1411qu0b wants to merge 1 commit intoethereum:masterfrom
qu0b wants to merge 1 commit intoethereum:masterfrom
Conversation
On newer macOS Docker Desktop versions, the top-level NetworkSettings.IPAddress from Docker's inspect API can be empty even though the container has a valid IP on the bridge network. This caused hiveproxy to bind to `:8081` (no IP), making HIVE_SIMULATOR=http://:8081 unreachable for the simulator container. Fall back to iterating NetworkSettings.Networks when the top-level IP is empty, and fail fast with a clear error if no IP is found at all.
Collaborator
|
The change looks OK to me. Let me know when you have tested it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetworkSettings.IPAddressfrom Docker's inspect API returns empty for containers on the default bridge network. This causes hiveproxy to reportaddr=:8081(no IP), resulting inHIVE_SIMULATOR=http://:8081which the simulator cannot reach (connection refused).NetworkSettings.Networksendpoint map when the top-level IP is empty — the canonical Docker API source for per-network IPs.Test plan