Skip to content

libdocker: fix empty container IP on Docker Desktop for macOS #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qu0b wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libdocker: fix empty container IP on Docker Desktop for macOS #1411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions internal/libdocker/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,29 @@ func (b *ContainerBackend) StartContainer(ctx context.Context, containerID strin
}
info.IP = container.NetworkSettings.IPAddress
info.MAC = container.NetworkSettings.MacAddress
// On some Docker setups (e.g. Docker Desktop for macOS), the top-level
// NetworkSettings.IPAddress field may be empty even though the container
// has an IP on the bridge network. Fall back to checking the per-network
// endpoint settings.
if info.IP == "" {
for name, network := range container.NetworkSettings.Networks {
if network.IPAddress != "" {
logger.Debug("using IP from network endpoint (top-level IPAddress was empty)", "network", name, "ip", network.IPAddress)
info.IP = network.IPAddress
if info.MAC == "" {
info.MAC = network.MacAddress
}
break
}
}
}
if info.IP == "" {
waiter.Close()
b.DeleteContainer(containerID)
info.Wait()
info.Wait = nil
return info, fmt.Errorf("container has no IP address (check Docker network settings)")
}

// Set up the port check if requested.
hasStarted := make(chan struct{})
Expand Down