chore: add format specifiers to interpolated string holes#4821
Merged
Conversation
Resolves the open GRA-INTERPOLATED-001 code scanning alerts. Untyped interpolation holes are replaced with %s (strings) and %O (exceptions) so the interpolations are type-checked. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dbrattli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 5 open code scanning alerts, which are the same rule:
GRA-INTERPOLATED-001— "Interpolated hole expression without format detected. Use prefix with the correct % to enforce type safety."src/Fable.Transforms/FSharp2Fable.fs:568src/Fable.Compiler/MSBuildCrackerResolver.fs:167src/Fable.Compiler/MSBuildCrackerResolver.fs:164src/Fable.Compiler/MSBuildCrackerResolver.fs:105src/Fable.Compiler/MSBuildCrackerResolver.fs:102Each untyped hole gets the specifier matching its value:
%sfor the twostringholes (targetFrameworkJson,json,unionCase.Name) and%Ofor the twoexnholes (ex), which keeps the existingToString()-based rendering.Output text is unchanged; this is purely about making the interpolations type-checked.
Verified with
dotnet build src/Fable.Compiler/Fable.Compiler.fsproj(succeeds, 0 warnings — this also coversFable.Transforms) anddotnet fantomas --checkon both files.🤖 Generated with Claude Code