Skip to content

chore: add format specifiers to interpolated string holes #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrattli merged 1 commit into from
Jul 19, 2026
+5 −5
Merged

chore: add format specifiers to interpolated string holes #4821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Fable.Compiler/MSBuildCrackerResolver.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ module private MSBuildCrackerResolver =
failwith
$"""Failed to parse MSBuild output
JSON:
{targetFrameworkJson}
%s{targetFrameworkJson}

Exception:
{ex}
%O{ex}
"""

let tf, tfs =
Expand Down Expand Up @@ -161,10 +161,10 @@ Exception:
failwith
$"""Failed to parse MSBuild output
JSON:
{json}
%s{json}

Exception:
{ex}
%O{ex}
"""

let items = jsonDocument.RootElement.GetProperty "Items"
Expand Down
2 changes: 1 addition & 1 deletion src/Fable.Transforms/FSharp2Fable.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ let private transformUnionCaseTest
match fableType with
| Fable.Any ->
return
$"Erased union case '{unionCase.Name}' is typed as 'obj' which cannot be tested at runtime (type test always evaluates to true). Use a more specific type or TypeScriptTaggedUnion instead."
$"Erased union case '%s{unionCase.Name}' is typed as 'obj' which cannot be tested at runtime (type test always evaluates to true). Use a more specific type or TypeScriptTaggedUnion instead."
|> addErrorAndReturnNull com ctx.InlinePath r
| _ ->
let kind = fableType |> Fable.TypeTest
Expand Down
Loading