Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add opencmw source block and rda3 client #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Add opencmw source block and rda3 client #199
Changes from all commits
4a0a949File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 76 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Replace this use of "insert" with "try_emplace".
Check failure on line 76 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
"std::forward" is never called on this forwarding reference argument.
Check warning on line 90 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Replace this use of "push" with "emplace".
Check failure on line 129 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed.
Check warning on line 132 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Reduce the number of nested "break" statements from 2 to 1 authorized.
Check failure on line 135 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
Check warning on line 145 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Replace with the version of "std::ranges::copy" that takes a range.
Check warning on line 155 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
ignoring return value of function declared with 'nodiscard' attribute
Check warning on line 156 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp
Extract this nested conditional operator into an independent statement.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.