v1.6.0 - Add fields and persist passthrough cols#200
Conversation
| cast(reversaldate as date) as reversal_date, | ||
| reversaldefer = 'T' as is_reversal_defer | ||
| reversaldefer = 'T' as is_reversal_defer, | ||
| _fivetran_deleted |
There was a problem hiding this comment.
filter remains
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `stg_netsuite2__customers` | New fields | | `is_inactive`, `comments`, `url`, `created_at` | Additional customer attributes now available in the staging model. Sourced from `isinactive`, `comments`, `url`, and `datecreated` in the `CUSTOMER` table. Remove from `customers_pass_through_columns` if currently included. | | ||
| | `stg_netsuite2__entities` | New field | | `date_created`, `_fivetran_deleted` | Remove from `entities_pass_through_columns` if currently included. | |
There was a problem hiding this comment.
Could this be a potential breaking change in Quickstart if Entities Pass Through Columns is set?
There was a problem hiding this comment.
Nope, this model isn't run in Quickstart nor are the pass through columns exposed there
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-jamie Some quick comments before approval.
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
Approved for pre-release.
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-jamie A few comments but looks good! This doesn't require a release review.
| # dbt_netsuite v1.6.0 | ||
| [PR #200](https://github.com/fivetran/dbt_netsuite/pull/200) includes the following updates: | ||
|
|
||
| ## Schema/Data Changes (--full-refresh required after upgrading) |
There was a problem hiding this comment.
Is the reason we don't bring in these rows because they don't impact Quickstart users?
|
stg_netsuite2__transaction_accounting_lines| New field | |amount_linked| |
|stg_netsuite2__transaction_lines| New field | |_fivetran_deleted| |
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `netsuite2__transaction_details`<br>`netsuite2__entity_subsidiary_relationships` | Filter on `VENDOR` data | Soft-deleted records excluded | Soft-deleted records included | | |
There was a problem hiding this comment.
Should we include stg_netsuite2__vendors here (or not since it doesn't impact Quickstart customers)?
There was a problem hiding this comment.
Thinking no since it doesn't impact them
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-jamie
added
docs:ready
2 participants
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
_fivetran_deletedto the transaction and transaction_line staging models_fivetran_deletedfilter from vendors staging modelSubmission Checklist
Changelog