-
Notifications
You must be signed in to change notification settings - Fork 42
v1.6.0 - Add fields and persist passthrough cols #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
23f0760
9b12a46
ef52c54
c011996
1ad3103
4f0770f
32e1c14
785178b
e7c5039
07c640c
8fa5cb1
eb99fbc
32bc436
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,49 @@ | ||
| # dbt_netsuite v1.6.0 | ||
| [PR #200](https://github.com/fivetran/dbt_netsuite/pull/200) includes the following updates: | ||
|
|
||
| ## Schema/Data Changes (--full-refresh required after upgrading) | ||
| **5 total changes • 2 possible breaking changes** | ||
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `netsuite2__transaction_details`<br>`netsuite2__entity_subsidiary_relationships` | Filter on `VENDOR` data | Soft-deleted records excluded | Soft-deleted records included | | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we include
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thinking no since it doesn't impact them |
||
| | `netsuite2__transaction_details`<br>`stg_netsuite2__transaction_accounting_lines` | New field | | `amount_linked` | The amount applied against another transaction (e.g. a payment applied to an invoice). | | ||
| | `stg_netsuite2__customers` | New fields | | `is_inactive`, `comments`, `url`, `created_at` | **Breaking Change (dbt Core):** Remove from `customers_pass_through_columns` if currently included. | | ||
| | `stg_netsuite2__entities` | New fields | | `date_created`, `_fivetran_deleted` | **Breaking Change (dbt Core):** Remove from `entities_pass_through_columns` if currently included. | | ||
| | `stg_netsuite2__transaction_lines`<br>`stg_netsuite2__transactions` | New field | | `_fivetran_deleted` | Soft-deleted `TRANSACTION` records are still filtered out. | | ||
|
|
||
| ## Feature Update | ||
| - Adds **Additional Customer Columns** (`customers_pass_through_columns` [in dbt Core](https://github.com/fivetran/dbt_netsuite#passing-through-additional-fields)) and **Additional Item Columns** (`items_pass_through_columns` [in dbt Core](https://github.com/fivetran/dbt_netsuite#passing-through-additional-fields)) to Quickstart, persisting chosen custom columns from the `CUSTOMER` and `ITEM` source tables. These fields are brought into `netsuite2__transaction_details`. | ||
|
|
||
| # dbt_netsuite v1.6.0-a1 | ||
| [PR #200](https://github.com/fivetran/dbt_netsuite/pull/200) includes the following updates: | ||
|
|
||
| ## Schema/Data Changes (--full-refresh required after upgrading) | ||
| **2 total changes • 0 possible breaking changes** | ||
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `netsuite2__transaction_details`<br>`netsuite2__entity_subsidiary_relationships` | Filter on `VENDOR` data | Soft-deleted records excluded | Soft-deleted records included | | | ||
| | `netsuite2__transaction_details` | New field | | `amount_linked` | The amount applied against another transaction (e.g. a payment applied to an invoice). | | ||
|
|
||
| <details><summary> <i>dbt Core/Additional Details</i> </summary> | ||
|
|
||
| **5 total changes • 2 possible breaking changes** | ||
|
fivetran-avinash marked this conversation as resolved.
|
||
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `stg_netsuite2__customers` | New fields | | `is_inactive`, `comments`, `url`, `created_at` | **Breaking Change:** Remove from `customers_pass_through_columns` if currently included. | | ||
| | `stg_netsuite2__entities` | New fields | | `date_created`, `_fivetran_deleted` | **Breaking Change:** Remove from `entities_pass_through_columns` if currently included. | | ||
| | `stg_netsuite2__transaction_accounting_lines` | New field | | `amount_linked` | | | ||
| | `stg_netsuite2__transaction_lines` | New field | | `_fivetran_deleted` | | | ||
| | `stg_netsuite2__transactions` | New field | | `_fivetran_deleted` | Soft-deleted records are still filtered out. | | ||
|
fivetran-avinash marked this conversation as resolved.
|
||
|
|
||
| </details> | ||
| <br> | ||
|
|
||
| ## Feature Update | ||
| - Adds **Additional Customer Columns** (`customers_pass_through_columns` [in dbt Core](https://github.com/fivetran/dbt_netsuite#passing-through-additional-fields)) and **Additional Item Columns** (`items_pass_through_columns` [in dbt Core](https://github.com/fivetran/dbt_netsuite#passing-through-additional-fields)) to Quickstart, persisting chosen custom columns from the `CUSTOMER` and `ITEM` source tables. These fields are brought into `netsuite2__transaction_details`. | ||
|
|
||
| # dbt_netsuite v1.5.1 | ||
| [PR #199](https://github.com/fivetran/dbt_netsuite/pull/199) includes the following updates: | ||
|
|
||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| _fivetran_synced,_fivetran_active,id,transactionnumber,type,memo,trandate,status,createddate,duedate,closedate,currency,entity,postingperiod,posting,isreversal,reversal,reversaldate,reversaldefer | ||
| 2022-05-27 13:41:13,TRUE,5914,,VendBill,,2017-05-07 0:00:00,A,2017-05-07 10:34:43,2017-05-05 0:00:00,,1,1570,,T,F,325251,2023-08-01 0:00:00,F | ||
| 2022-05-27 13:41:13,TRUE,3,,VendBill,,2015-09-10 0:00:00,B,2017-05-12 3:41:25,2015-10-09 0:00:00,2015-10-05 0:00:00,1,36,251,T,F,325252,2023-08-02 0:00:00,F | ||
| 2022-05-27 13:41:13,TRUE,302,,VendBill,ZZZZZ,2016-03-20 0:00:00,B,2017-04-25 3:41:25,2016-04-19 0:00:00,2017-05-07 0:00:00,1,5,261,T,F,325323,2023-08-03 0:00:00,F | ||
| 2022-05-26 13:41:13,FALSE,302,,VendBill,ZZZZZ,2016-03-20 0:00:00,B,2017-04-25 3:41:25,2016-04-19 0:00:00,2017-05-07 0:00:00,1,5,261,T,F,325323,2023-08-03 0:00:00,F | ||
| _fivetran_synced,_fivetran_active,_fivetran_deleted,id,transactionnumber,type,memo,trandate,status,createddate,duedate,closedate,currency,entity,postingperiod,posting,isreversal,reversal,reversaldate,reversaldefer | ||
| 2022-05-27 13:41:13,TRUE,FALSE,5914,,VendBill,,2017-05-07 0:00:00,A,2017-05-07 10:34:43,2017-05-05 0:00:00,,1,1570,,T,F,325251,2023-08-01 0:00:00,F | ||
| 2022-05-27 13:41:13,TRUE,FALSE,3,,VendBill,,2015-09-10 0:00:00,B,2017-05-12 3:41:25,2015-10-09 0:00:00,2015-10-05 0:00:00,1,36,251,T,F,325252,2023-08-02 0:00:00,F | ||
| 2022-05-27 13:41:13,TRUE,FALSE,302,,VendBill,ZZZZZ,2016-03-20 0:00:00,B,2017-04-25 3:41:25,2016-04-19 0:00:00,2017-05-07 0:00:00,1,5,261,T,F,325323,2023-08-03 0:00:00,F | ||
| 2022-05-26 13:41:13,FALSE,FALSE,302,,VendBill,ZZZZZ,2016-03-20 0:00:00,B,2017-04-25 3:41:25,2016-04-19 0:00:00,2017-05-07 0:00:00,1,5,261,T,F,325323,2023-08-03 0:00:00,F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reason we don't bring in these rows because they don't impact Quickstart users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep