Added Compiler Wrapper script for Preprocessing using fypp by arteevraina · Pull Request #729 · fortran-lang/fpm

arteevraina · 2022-08-14T13:11:55Z

This Pull Request adds a compiler wrapper script for preprocessing the .fypp files and storing them inside the build directory.
Also makes the macros defined in manifest available while running tests.

arteevraina · 2022-08-20T08:42:44Z

Hi @awvwgk , Can you review this new script that I created using python ?

awvwgk · 2022-08-20T09:39:57Z

This logic can compile the example packages checked in with

fpm run -- build -C example_packages/preprocess_fypp/ --compiler "$PWD/fypp-gfortran.py"

arteevraina · 2022-08-20T16:03:02Z

@awvwgk Removed the unused output_dir from script. I think this PR is ready for review.

awvwgk · 2022-08-20T16:34:50Z

There seems to be an issue with the macro scope. The macros set in the manifest are not visible when compiling tests:

❯ cat stdlib/fpm.toml
name = "stdlib"

[dev-dependencies]
test-drive.git = "https://github.com/fortran-lang/test-drive.git"

[build]
auto-examples = false
auto-tests = true

[preprocess.cpp]
macros = [
  "PROJECT_VERSION_MAJOR=0",
  "PROJECT_VERSION_MINOR=1",
  "PROJECT_VERSION_PATCH=0",
  "MAXRANK=4",
]
❯ fpm run -- build --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'
...
libstdlib.a                            done.
[100%] Project compiled successfully.
fpm: Leaving directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'

❯ fpm run -- test --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'
pengyhash.c                            done.
nmhash_scalar.c                        done.
waterhash.c                            done.
nmhash.c                               done.
stdlib_system.F90                      done.
stdlib_array.f90                       done.
stdlib_kinds.fypp                      done.
testdrive.F90                          done.
test_sleep.f90                         done.
stdlib_ascii.fypp                      done.
stdlib_selection.fypp                  done.
stdlib_specialfunctions.f90            done.
stdlib_io_npy.fypp                     done.
stdlib_hash_64bit.fypp                 done.
stdlib_optval.fypp                     done.
stdlib_hash_32bit.fypp                 done.
stdlib_stats.fypp                      done.
stdlib_quadrature.fypp                 done.
test_selection.fypp                    failed.
[ 10%] Compiling...
./include/common.fypp:4: error: exception occurred when setting variable(s) 'PROJECT_VERSION' to '"{}.{}.{}".format(PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, PROJECT_VERSION_PATCH)' [FyppFatalError]
error: name 'PROJECT_VERSION_MAJOR' is not defined [NameError]
Traceback (most recent call last):
  File "/home/awvwgk/projects/src/git/fortran-package-manager/fypp-gfortran.py", line 34, in <module>
    subprocess.run(
  File "/usr/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['fypp', '-n', 'test/selection/test_selection.fypp', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/stdlib/test_selection_test_selection.fypp.f90', '-I./include', '-Ibuild/fypp-gfortran.py_FD8F41EC3CDC3776', '-Ibuild/fypp-gfortran.py_3CB5FB1E2B6F713E']' returned non-zero exit status 1.

awvwgk · 2022-08-20T16:41:19Z

Good news is we can already compile and run all examples if build.auto-examples = true is set.

arteevraina · 2022-08-20T16:45:37Z

There seems to be an issue with the macro scope. The macros set in the manifest are not visible when compiling tests:

❯ cat stdlib/fpm.toml
name = "stdlib"

[dev-dependencies]
test-drive.git = "https://github.com/fortran-lang/test-drive.git"

[build]
auto-examples = false
auto-tests = true

[preprocess.cpp]
macros = [
  "PROJECT_VERSION_MAJOR=0",
  "PROJECT_VERSION_MINOR=1",
  "PROJECT_VERSION_PATCH=0",
  "MAXRANK=4",
]
❯ fpm run -- build --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'
...
libstdlib.a                            done.
[100%] Project compiled successfully.
fpm: Leaving directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'

❯ fpm run -- test --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'
pengyhash.c                            done.
nmhash_scalar.c                        done.
waterhash.c                            done.
nmhash.c                               done.
stdlib_system.F90                      done.
stdlib_array.f90                       done.
stdlib_kinds.fypp                      done.
testdrive.F90                          done.
test_sleep.f90                         done.
stdlib_ascii.fypp                      done.
stdlib_selection.fypp                  done.
stdlib_specialfunctions.f90            done.
stdlib_io_npy.fypp                     done.
stdlib_hash_64bit.fypp                 done.
stdlib_optval.fypp                     done.
stdlib_hash_32bit.fypp                 done.
stdlib_stats.fypp                      done.
stdlib_quadrature.fypp                 done.
test_selection.fypp                    failed.
[ 10%] Compiling...
./include/common.fypp:4: error: exception occurred when setting variable(s) 'PROJECT_VERSION' to '"{}.{}.{}".format(PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, PROJECT_VERSION_PATCH)' [FyppFatalError]
error: name 'PROJECT_VERSION_MAJOR' is not defined [NameError]
Traceback (most recent call last):
  File "/home/awvwgk/projects/src/git/fortran-package-manager/fypp-gfortran.py", line 34, in <module>
    subprocess.run(
  File "/usr/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['fypp', '-n', 'test/selection/test_selection.fypp', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/stdlib/test_selection_test_selection.fypp.f90', '-I./include', '-Ibuild/fypp-gfortran.py_FD8F41EC3CDC3776', '-Ibuild/fypp-gfortran.py_3CB5FB1E2B6F713E']' returned non-zero exit status 1.

Sure will check this.

arteevraina · 2022-08-21T11:47:01Z

There seems to be an issue with the macro scope. The macros set in the manifest are not visible when compiling tests:

❯ cat stdlib/fpm.toml
name = "stdlib"

[dev-dependencies]
test-drive.git = "https://github.com/fortran-lang/test-drive.git"

[build]
auto-examples = false
auto-tests = true

[preprocess.cpp]
macros = [
  "PROJECT_VERSION_MAJOR=0",
  "PROJECT_VERSION_MINOR=1",
  "PROJECT_VERSION_PATCH=0",
  "MAXRANK=4",
]
❯ fpm run -- build --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'
...
libstdlib.a                            done.
[100%] Project compiled successfully.
fpm: Leaving directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'

❯ fpm run -- test --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/awvwgk/projects/src/git/fortran-package-manager/stdlib'
pengyhash.c                            done.
nmhash_scalar.c                        done.
waterhash.c                            done.
nmhash.c                               done.
stdlib_system.F90                      done.
stdlib_array.f90                       done.
stdlib_kinds.fypp                      done.
testdrive.F90                          done.
test_sleep.f90                         done.
stdlib_ascii.fypp                      done.
stdlib_selection.fypp                  done.
stdlib_specialfunctions.f90            done.
stdlib_io_npy.fypp                     done.
stdlib_hash_64bit.fypp                 done.
stdlib_optval.fypp                     done.
stdlib_hash_32bit.fypp                 done.
stdlib_stats.fypp                      done.
stdlib_quadrature.fypp                 done.
test_selection.fypp                    failed.
[ 10%] Compiling...
./include/common.fypp:4: error: exception occurred when setting variable(s) 'PROJECT_VERSION' to '"{}.{}.{}".format(PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, PROJECT_VERSION_PATCH)' [FyppFatalError]
error: name 'PROJECT_VERSION_MAJOR' is not defined [NameError]
Traceback (most recent call last):
  File "/home/awvwgk/projects/src/git/fortran-package-manager/fypp-gfortran.py", line 34, in <module>
    subprocess.run(
  File "/usr/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['fypp', '-n', 'test/selection/test_selection.fypp', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/stdlib/test_selection_test_selection.fypp.f90', '-I./include', '-Ibuild/fypp-gfortran.py_FD8F41EC3CDC3776', '-Ibuild/fypp-gfortran.py_3CB5FB1E2B6F713E']' returned non-zero exit status 1.

One more question regarding this.
From the logs it seems like you were able to successfully compile the files in src directory. Other than adding the fpm.toml in stdlib root directory. Did you made any changes with the source files ?

I am asking this because I am getting a module as duplicate when trying to build the source directory.

 Warning: Module estop in ./src/f18estop.f90 is a duplicate
<ERROR>*build_model*:Error: One or more duplicate module names found.

cc @awvwgk

awvwgk · 2022-08-21T11:50:11Z

From the logs it seems like you were able to successfully compile the files in src directory. Other than adding the fpm.toml in stdlib root directory. Did you made any changes with the source files ?

Just two submodule and a file rename.

diff --git a/src/common.fypp b/include/common.fypp
similarity index 100%
rename from src/common.fypp
rename to include/common.fypp
diff --git a/src/f08estop.f90 b/src/f08estop.f90
index 81c77f4..3fb0440 100644
--- a/src/f08estop.f90
+++ b/src/f08estop.f90
@@ -1,4 +1,4 @@
-submodule (stdlib_error) estop
+submodule (stdlib_error) f08estop
 
 implicit none
 
diff --git a/src/f18estop.f90 b/src/f18estop.f90
index 59fd0c9..241665a 100644
--- a/src/f18estop.f90
+++ b/src/f18estop.f90
@@ -1,4 +1,4 @@
-submodule (stdlib_error) estop
+submodule (stdlib_error) f18estop
 
 implicit none
 
@@ -26,4 +26,4 @@ else
 endif
 end procedure
 
-end submodule estop
+end submodule f18estop

arteevraina · 2022-08-23T16:48:04Z

Hi @awvwgk ,

I have fixed the macros not being available while running tests error.
Now, I am facing some other while compiling tests in stdlib

test/stats/test_mean_f03.fypp:89:30:

   89 |                     , sum(abs(mean(d8_${k1}$, ${dim}$) -&
      |                              1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:89:30:

   89 |                     , sum(abs(mean(d8_${k1}$, ${dim}$) -&
      |                              1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:89:30:

   89 |                     , sum(abs(mean(d8_${k1}$, ${dim}$) -&
      |                              1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:78:38:

   78 |         call check(error, ieee_is_nan(mean(d8_${k1}$, .false.))&
      |                                      1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:68:26:

   68 |         call check(error, mean(d8_${k1}$), sum(real(d8_${k1}$, dp))/real(size(d8_${k1}$), dp)&
      |                          1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:286:8:

  286 |     use test_stats_meanf03, only : collect_stats_meanf03
      |        1
Fatal Error: Cannot open module file ‘test_stats_meanf03.mod’ for reading at (1): No such file or directory
compilation terminated.

Working on a fix for this as well in stdlib.

arteevraina · 2022-08-24T07:23:56Z

Hi @awvwgk ,

I have fixed the macros not being available while running tests error. Now, I am facing some other while compiling tests in stdlib

test/stats/test_mean_f03.fypp:89:30:

   89 |                     , sum(abs(mean(d8_${k1}$, ${dim}$) -&
      |                              1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:89:30:

   89 |                     , sum(abs(mean(d8_${k1}$, ${dim}$) -&
      |                              1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:89:30:

   89 |                     , sum(abs(mean(d8_${k1}$, ${dim}$) -&
      |                              1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:78:38:

   78 |         call check(error, ieee_is_nan(mean(d8_${k1}$, .false.))&
      |                                      1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:68:26:

   68 |         call check(error, mean(d8_${k1}$), sum(real(d8_${k1}$, dp))/real(size(d8_${k1}$), dp)&
      |                          1
Error: There is no specific function for the generic ‘mean’ at (1)
test/stats/test_mean_f03.fypp:286:8:

  286 |     use test_stats_meanf03, only : collect_stats_meanf03
      |        1
Fatal Error: Cannot open module file ‘test_stats_meanf03.mod’ for reading at (1): No such file or directory
compilation terminated.

Working on a fix for this as well in stdlib.

More updates,

So, I was able to compile all the tests except these two files :

test/stats/test_mean_f03.fypp which is giving the errors I mentioned in the last comment.
test/hash_functions/test_hash_functions.f90 which is giving me this error :
undefined reference to generate_all_c_hash

I am currently trying to fix these and then we will be able to compile all the tests.

cc: @awvwgk

jvdp1 · 2022-08-24T07:43:12Z

More updates,

So, I was able to compile all the tests except these two files :

test/stats/test_mean_f03.fypp which is giving the errors I mentioned in the last comment.

test_mean_f03 requires that stdlib is compiled for arrays with at least 4 dimentions (-DMAXRANK=4). Is this the case?

test/hash_functions/test_hash_functions.f90 which is giving me this error :
undefined reference to generate_all_c_hash

test_hash_functions.f90 depends on C code (generate_all_c_hash.c and others). I guess that fpm should be told that it should compile C codes too.

arteevraina · 2022-08-24T12:16:06Z

More updates,
So, I was able to compile all the tests except these two files :

test/stats/test_mean_f03.fypp which is giving the errors I mentioned in the last comment.

test_mean_f03 requires that stdlib is compiled for arrays with at least 4 dimentions (-DMAXRANK=4). Is this the case?

test/hash_functions/test_hash_functions.f90 which is giving me this error :
undefined reference to generate_all_c_hash

test_hash_functions.f90 depends on C code (generate_all_c_hash.c and others). I guess that fpm should be told that it should compile C codes too.

I think fpm already has the ability to compiler .c files, but generate_all_c_hash is an inside the file with the extension .cpp and that's why it is not getting compiled. Should I allow fpm to compile .cpp files or if possible migrate the function to .c file ?

 fpm run -- test --compiler "$PWD/fypp-gfortran.py" --flag -fno-range-check -C stdlib
Project is up to date
fpm: Entering directory '/home/arteev/new_fpm/fpm/stdlib'
nmhash.c                               done.
pengyhash.c                            done.
waterhash.c                            done.
nmhash_scalar.c                        done.
stdlib_array.f90                       done.
stdlib_kinds.fypp                      done.

jvdp1 · 2022-08-25T19:29:49Z

The issue for test_mean_f03 is that a directory build/fypp-gfortran_xxx is not provided to gfortran with the -I option. I am looking how to solve this.

cc @LKedward

arteevraina · 2022-08-26T10:26:57Z

@jvdp1 @awvwgk @LKedward

Should I work on separate branch for cpp support in fpm or should I handle that in this branch only ?

jvdp1 · 2022-08-26T10:57:22Z

Yes, working on a separate branch dedicated to the cpp support is wise. You can later merge it with your current branch. Le ven. 26 août 2022 à 12:27, Arteev Raina ***@***.***> a écrit :

…

@jvdp1 <https://github.com/jvdp1> @awvwgk <https://github.com/awvwgk> @LKedward <https://github.com/LKedward> Should I work on separate branch for cpp support in fpm or should I handle that in this branch only ? — Reply to this email directly, view it on GitHub <#729 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5RO7HTPOHHIR6ZPA7U7DDV3CLXXANCNFSM56P3EZIQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

arteevraina · 2022-08-26T17:48:07Z

I know as we are parsing the #include statements for .c files. Similarly, should we do it also for .cpp files? and add it to the include_dependendies
https://github.com/fortran-lang/fpm/blob/main/src/fpm_source_parsing.f90#L492

cc : @jvdp1 @LKedward

jvdp1 · 2022-08-29T19:17:07Z

Yes, working on a separate branch dedicated to the cpp support is wise. You can later merge it with your current branch.

Well, I am not sure how to solve this issue. @awvwgk @LKedward are most likely more able to do it than me.

jvdp1 · 2022-08-29T19:17:41Z

I know as we are parsing the #include statements for .c files. Similarly, should we do it also for .cpp files? and add it to the include_dependendies https://github.com/fortran-lang/fpm/blob/main/src/fpm_source_parsing.f90#L492

cc : @jvdp1 @LKedward

This has been answered in the other PR, right?

arteevraina · 2022-08-30T06:39:32Z

I know as we are parsing the #include statements for .c files. Similarly, should we do it also for .cpp files? and add it to the include_dependendies https://github.com/fortran-lang/fpm/blob/main/src/fpm_source_parsing.f90#L492
cc : @jvdp1 @LKedward

This has been answered in the other PR, right?

Yes, It has been resolved.

arteevraina · 2022-09-04T12:18:52Z

The patch in PR #743 (@LKedward ) will fix the linking issue for us. But, there are two files in stdlib called nmhash.c & nmhash_scalar.c which contains definition of a function with same names nmhash32_test & nmhash32x_test. Should we opt for renaming those inside the stdlib itself ?

(env) arteev@pavilion:~/fpm$ fpm run -- test --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/arteev/fpm/stdlib'
test_always_skip                       failed.
[100%] Compiling...
/usr/bin/ld: build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash.c.o: in function `nmhash32_test':
nmhash.c:(.text+0x2b94): multiple definition of `nmhash32_test'; build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash_scalar.c.o:nmhash_scalar.c:(.text+0x1970): first defined here
/usr/bin/ld: build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash.c.o: in function `nmhash32x_test':
nmhash.c:(.text+0x2bc3): multiple definition of `nmhash32x_test'; build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash_scalar.c.o:nmhash_scalar.c:(.text+0x199f): first defined here
collect2: error: ld returned 1 exit status
Traceback (most recent call last):
  File "/home/arteev/fpm/fypp-gfortran.py", line 14, in <module>
    subprocess.run(["gfortran"] + args, check=True)
  File "/usr/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['gfortran', '-cpp', '-Wall', '-Wextra', '-Wimplicit-interface', '-fPIC', '-fmax-errors=1', '-g', '-fcheck=bounds', '-fcheck=array-temps', '-fbacktrace', '-fcoarray=single', '-I./include', 'build/fypp-gfortran.py_3CB5FB1E2B6F713E/stdlib/test_test_always_skip.f90.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_generate_hash_arrays.cpp.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_waterhash.c.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash_scalar.c.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash.c.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_SpookyV2.cpp.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_SpookyV2Test.cpp.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_pengyhash.c.o', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/stdlib/libstdlib.a', '-lstdc++', '-o', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/test/test_always_skip']' returned non-zero exit status 1.
<ERROR> Compilation failed for object " test_always_skip "
<ERROR>stopping due to failed compilation
STOP 1
<ERROR> Execution failed for object " fpm "
<ERROR>*cmd_run*:stopping due to failed executions
STOP 1

cc : @awvwgk

jvdp1 · 2022-09-04T12:33:47Z

The patch in PR #743 (@LKedward ) will fix the linking issue for us. But, there are two files in stdlib called nmhash.c & nmhash_scalar.c which contains definition of a function with same names nmhash32_test & nmhash32x_test. Should we opt for renaming those inside the stdlib itself ?

(env) arteev@pavilion:~/fpm$ fpm run -- test --compiler "$PWD/fypp-gfortran.py" -C stdlib
Project is up to date
fpm: Entering directory '/home/arteev/fpm/stdlib'
test_always_skip                       failed.
[100%] Compiling...
/usr/bin/ld: build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash.c.o: in function `nmhash32_test':
nmhash.c:(.text+0x2b94): multiple definition of `nmhash32_test'; build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash_scalar.c.o:nmhash_scalar.c:(.text+0x1970): first defined here
/usr/bin/ld: build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash.c.o: in function `nmhash32x_test':
nmhash.c:(.text+0x2bc3): multiple definition of `nmhash32x_test'; build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash_scalar.c.o:nmhash_scalar.c:(.text+0x199f): first defined here
collect2: error: ld returned 1 exit status
Traceback (most recent call last):
  File "/home/arteev/fpm/fypp-gfortran.py", line 14, in <module>
    subprocess.run(["gfortran"] + args, check=True)
  File "/usr/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['gfortran', '-cpp', '-Wall', '-Wextra', '-Wimplicit-interface', '-fPIC', '-fmax-errors=1', '-g', '-fcheck=bounds', '-fcheck=array-temps', '-fbacktrace', '-fcoarray=single', '-I./include', 'build/fypp-gfortran.py_3CB5FB1E2B6F713E/stdlib/test_test_always_skip.f90.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_generate_hash_arrays.cpp.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_waterhash.c.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash_scalar.c.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_nmhash.c.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_SpookyV2.cpp.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_SpookyV2Test.cpp.o', 'build/fypp-gfortran.py_5ECC72CE4779CCDA/stdlib/test_hash_functions_pengyhash.c.o', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/stdlib/libstdlib.a', '-lstdc++', '-o', 'build/fypp-gfortran.py_FD8F41EC3CDC3776/test/test_always_skip']' returned non-zero exit status 1.
<ERROR> Compilation failed for object " test_always_skip "
<ERROR>stopping due to failed compilation
STOP 1
<ERROR> Execution failed for object " fpm "
<ERROR>*cmd_run*:stopping due to failed executions
STOP 1

I believe that nmash.c is even not used and could be removed from stdlib. It is virtually the same file as nmash_scalar.c, as only the included .h is different. Furthermore, the nmash_scalar.h file could be avoided by providing the right macros for the nmash.h file.

arteevraina · 2022-09-07T18:47:50Z

The issue for test_mean_f03 is that a directory build/fypp-gfortran_xxx is not provided to gfortran with the -I option. I am looking how to solve this.

cc @LKedward

Hi @jvdp1, Sorry for the late response on this. I think if we look on the command that is currently failing, we have two build/fypp-gfortran_xxx that are provided to gfortran with -I flag.

Command '['gfortran', '-c', '-cpp', '-fno-range-check', '-I./include', '-J', 'build/fypp-gfortran.py_5D5C753FD9D7515D', '-Ibuild/fypp-gfortran.py_5D5C753FD9D7515D', '-Ibuild/fypp-gfortran.py_7982C4100533BAB9', '-o', 'build/fypp-gfortran.py_5D5C753FD9D7515D/stdlib/test_stats_test_mean_f03.fypp.o', 'build/fypp-gfortran.py_5D5C753FD9D7515D/stdlib/test_stats_test_mean_f03.fypp.f90']' returned non-zero exit status 1.

jvdp1 · 2023-01-24T20:24:43Z

@awvwgk @arteevraina What should be done in this PR to merge it?

arteevraina · 2023-01-25T17:06:50Z

Hi @jvdp1,
I think three PRs including this are interconnected.

I will try to look again in the information shared in the PRs and try to resolve them one by one.

jvdp1 · 2024-01-07T20:14:22Z

@arteevraina @awvwgk @fortran-lang/fpm The issues mentioned in this thread seem to have been solved. At least I can compile this branch of stdlib with the wrapper script in this PR.

What should be done to finalize this branch? This wrapper script would be a better alternative than this proposition and partially solve this issue and this issue

cc: @jalvesz

jalvesz · 2024-01-07T20:47:30Z

This is extremely interesting indeed!! it would make the whole process quite smooth! One question, I see that there is a fypp-gfortran.py script. Is this meant to be compiler dependent? Can't the pre-processing and the compiler choice for compiling be decoupled? Or is this meant to be used by the preprocessor option in the toml file as explained here https://fpm.fortran-lang.org/spec/manifest.html?highlight=fypp# such that it should be transparent for the user?
(sorry for the question, I'm just reading through the PR)

jvdp1 · 2024-01-07T21:13:19Z

One question, I see that there is a fypp-gfortran.py script. Is this meant to be compiler dependent? Can't the pre-processing and the compiler choice for compiling be decoupled?

IMO This was aimed to be a temporary solution before the full integration into fpm. However, I believe that the wrapper script could be made more flexible, e.g., by relying on the environment variables FPM_FC or FC.

arteevraina marked this pull request as draft August 14, 2022 13:12

awvwgk self-requested a review August 20, 2022 08:58

awvwgk reviewed Aug 20, 2022

View reviewed changes

Comment thread fypp-gfortran.py Outdated

arteevraina marked this pull request as ready for review August 20, 2022 16:02

jvdp1 reviewed Aug 24, 2022

View reviewed changes

Comment thread fypp-gfortran.py

ivan-pi mentioned this pull request Aug 31, 2022

Using fypp through the Intel Fortran compilers aradi/fypp#24

Open

arteevraina force-pushed the fypp-support branch from 188a61b to bd53a84 Compare September 1, 2022 13:06

arteevraina added 2 commits September 6, 2022 12:18

feat: added basic script for preprocessing and saving generated files

1487a92

docs: added example package

9bcc10c

arteevraina and others added 7 commits September 6, 2022 12:18

fix: changed the comments and removed unused code

dcd7832

refactor: remove .mod file

baaef36

feat: added python script for fypp

38686a7

docs: improved the file logic

689eed7

Only preprocess current files

47ee622

refactor: removed unused output dir

82d368c

fix: macros available while running tests

a49a97a

arteevraina force-pushed the fypp-support branch from bd53a84 to a49a97a Compare September 6, 2022 06:59

arteevraina mentioned this pull request Sep 6, 2022

refactor: change in structure of stdlib in order to compiler it using fypp script fortran-lang/stdlib#675

Open

awvwgk mentioned this pull request Oct 5, 2022

Strange interaction with a linter #769

Closed

jvdp1 mentioned this pull request Mar 17, 2023

Push stdlib version to the stdlib-fpm branch fortran-lang/stdlib#701

Closed

jvdp1 mentioned this pull request Jan 9, 2024

Support of additional suffixes of Fortran files for preprocessing #979

Closed

jvdp1 mentioned this pull request Apr 9, 2024

fpm deployment: workaround for case-insensitive fs fortran-lang/stdlib#790

Merged

Conversation

arteevraina commented Aug 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteevraina commented Aug 20, 2022

Uh oh!

Uh oh!

awvwgk commented Aug 20, 2022

Uh oh!

arteevraina commented Aug 20, 2022

Uh oh!

awvwgk commented Aug 20, 2022

Uh oh!

awvwgk commented Aug 20, 2022

Uh oh!

arteevraina commented Aug 20, 2022

Uh oh!

arteevraina commented Aug 21, 2022

Uh oh!

awvwgk commented Aug 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteevraina commented Aug 23, 2022

Uh oh!

arteevraina commented Aug 24, 2022

Uh oh!

Uh oh!

jvdp1 commented Aug 24, 2022

Uh oh!

arteevraina commented Aug 24, 2022

Uh oh!

jvdp1 commented Aug 25, 2022

Uh oh!

arteevraina commented Aug 26, 2022

Uh oh!

jvdp1 commented Aug 26, 2022 via email

Uh oh!

arteevraina commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvdp1 commented Aug 29, 2022

Uh oh!

jvdp1 commented Aug 29, 2022

Uh oh!

arteevraina commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteevraina commented Sep 4, 2022

Uh oh!

jvdp1 commented Sep 4, 2022

Uh oh!

arteevraina commented Sep 7, 2022

Uh oh!

jvdp1 commented Jan 24, 2023

Uh oh!

arteevraina commented Jan 25, 2023

Uh oh!

jvdp1 commented Jan 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jalvesz commented Jan 7, 2024

Uh oh!

jvdp1 commented Jan 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arteevraina commented Aug 14, 2022 •

edited

Loading

awvwgk commented Aug 21, 2022 •

edited

Loading

arteevraina commented Aug 26, 2022 •

edited

Loading

arteevraina commented Aug 30, 2022 •

edited

Loading

jvdp1 commented Jan 7, 2024 •

edited

Loading