refactor: change in structure of stdlib in order to compiler it using fypp script by arteevraina · Pull Request #675 · fortran-lang/stdlib

arteevraina · 2022-09-06T16:34:18Z

This Pull Request makes few structural changes in stdlib to make get it compiled using the compiler wrapper script here.

jvdp1 · 2022-09-06T17:29:47Z

To solve the issues, the following should be done:

In CMakeLists.txt: add "-I${PROJECT_SOURCE_DIR}/include" in the definition of the fyppFlags
In test/CMakeLists.txt: remove the lines:

list(
  APPEND fyppFlags
  "-I${PROJECT_SOURCE_DIR}/src"
)

jvdp1 · 2022-09-06T17:44:11Z

Did you also solve the issues with:

test_mean_f03.fypp
nmash.c
?

arteevraina · 2022-09-07T18:49:08Z

Did you also solve the issues with:
* `test_mean_f03.fypp`

* `nmash.c`
  ?

For nmhash.c, I have fixed the issues. Will push it.
For test_mean_f03.fypp, Still having the same issue. I have not been able to resolve it. Still working on it.

arteevraina · 2022-09-08T17:09:01Z

@awvwgk @jvdp1

CMake build is failing since, it is not able to find test_always_fail.f90 & test_always_skip.f90 as I have deleted those files.

awvwgk · 2022-09-08T17:17:55Z

CMake build is failing since, it is not able to find test_always_fail.f90 & test_always_skip.f90 as I have deleted those files.

Than you also have to remove the declaration of the tests from the CMake build files.

arteevraina · 2022-09-09T06:23:22Z

I remember we moved the common.fypp file from src to include directory. But seems like fpm-deployment script was not updated to handle that.

@awvwgk @jvdp1

arteevraina · 2022-09-09T15:32:55Z

I remember we moved the common.fypp file from src to include directory. But seems like fpm-deployment script was not updated to handle that.

@awvwgk @jvdp1

Should I change the include path of common.fypp in the .fypp files from which common.fypp not found error is coming in the fpm-deployment ?

cc: @awvwgk @jvdp1

jvdp1 · 2022-09-09T16:59:51Z

Should I change the include path of common.fypp in the .fypp files from which common.fypp not found error is coming in the fpm-deployment ?

No, I don't think so. Instead the variable fyflags in the fpm-deployement should be updated with the flag -I (similar to for the CMake files)
E.g., in my directory, I must adapt the fpm-deployment as follows:

...
fyflags="${fyglags} -I include"
...

jvdp1 · 2022-09-11T12:17:47Z

+auto-examples = false
+auto-tests = true
+
+[preprocess.cpp]


Should it be

Suggested change

[preprocess.cpp]

[preprocess.fypp]

?
As far as I remember, CPP is not used within stdlib.

Yes, that is not used. But, we have not enabled fypp inside fpm as of now. So, it cannot identity it as a valid preprocessor. Considering fypp-gfortran.py as a temporary solution, I think when we have fypp integrated inside fpm then I think we should rename it as fypp instead of cpp.

jvdp1 · 2022-09-11T12:32:21Z

To solve the issue with the Build-API-Docs, the directory include should be added/mentioned in the file API-doc-FORD-file.md (probably under the directive include:).

arteevraina · 2022-09-24T06:09:08Z

Hi @jvdp1, I still seem to face some issues with docs ci. Can you help me in resolving this?

zoziha · 2022-09-24T06:57:04Z

This should be related to the version update of FORD, see #673 .

jvdp1 · 2022-09-24T18:56:30Z

This should be related to the version update of FORD, see #673 .

@arteevraina Indeed it seems to be related to #673

jvdp1 · 2022-09-25T13:11:38Z

@arteevraina Could you rebase your PR such that @zoziha chnages (#681) are also integrated into this PR, please?
Hopefully this will solve the issue with the CI.

… fypp script

…e file

…ment script

This reverts commit 16d8b86.

awvwgk · 2022-09-25T17:22:54Z

+  "PROJECT_VERSION_MAJOR=0",
+  "PROJECT_VERSION_MINOR=1",
+  "PROJECT_VERSION_PATCH=0",


Should we support extracting those values automatically in fpm?

Yes, I think we should add support to extract them for the version number ?
I will take up this task.

PR created for this fortran-lang/fpm#766

jvdp1 · 2022-10-03T19:01:09Z

+```sh
+git clone https://github.com/fortran-lang/fpm.git
+```


Why is that provided? IMO a link to fpm should be sufficient.

awvwgk reviewed Sep 8, 2022

View reviewed changes

Comment thread CMakeLists.txt Outdated

jvdp1 reviewed Sep 8, 2022

View reviewed changes

Comment thread test/stats/test_mean_f03.fypp Outdated

arteevraina changed the title ~~refactor: change in structure of stdlib in order to compiler it using … fypp script~~ refactor: change in structure of stdlib in order to compiler it using fypp script Sep 9, 2022

arteevraina marked this pull request as ready for review September 9, 2022 16:31

jvdp1 reviewed Sep 11, 2022

View reviewed changes

arteevraina added 12 commits September 25, 2022 20:13

refactor: change in structure of stdlib in order to compiler it using…

c46d76e

… fypp script

fix: skip tests in test_mean based on MAXRANK

6d0bbbc

refactor: remove nmhash.c file

4e4b0d2

refactor: remove test_always_skip & test_always_fail files

21212c8

fix: failing ci

35ed9b6

fix: append include directory later

1608e14

fix: remove test_always_fail & test_always_skip declaration from CMak…

d036311

…e file

fix: failing ci for common.fypp

0d4fc91

refactor: replace Rank 7 with Rank > 7

e88c922

fix: remove test_always_skip & test_always_fail reference from deploy…

9877ed4

…ment script

fix: fpm deployment script for removing files

2a6c429

fix: replace path of common.fypp

21748c0

arteevraina added 5 commits September 25, 2022 20:13

fix: remove reference of common.fypp

f941556

Revert "fix: replace path of common.fypp"

5904f32

This reverts commit 16d8b86.

fix: fyflags by appending include directory

cdebc20

docs: added include directory in documentation markdown

2b63915

docs: added documentation regarding building with fypp script

7c99e70

arteevraina force-pushed the structure-change branch from 6269e49 to 7c99e70 Compare September 25, 2022 14:44

awvwgk reviewed Sep 25, 2022

View reviewed changes

arteevraina mentioned this pull request Oct 2, 2022

feat: ability to read project major, minor & patch macros fortran-lang/fpm#766

Open

jvdp1 reviewed Oct 3, 2022

View reviewed changes

arteevraina mentioned this pull request Jan 25, 2023

Added Compiler Wrapper script for Preprocessing using fypp fortran-lang/fpm#729

Open

jvdp1 added a commit to jvdp1/stdlib that referenced this pull request Jan 7, 2024

Modif of test_mean_f03 following fortran-lang#675 by @arteebraina

7a2bffa

jvdp1 mentioned this pull request Jan 7, 2024

Minor changes related to fypp prepocessing #758

Merged

Conversation

arteevraina commented Sep 6, 2022

Uh oh!

jvdp1 commented Sep 6, 2022

Uh oh!

jvdp1 commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteevraina commented Sep 7, 2022

Uh oh!

Uh oh!

arteevraina commented Sep 8, 2022

Uh oh!

awvwgk commented Sep 8, 2022

Uh oh!

Uh oh!

arteevraina commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteevraina commented Sep 9, 2022

Uh oh!

jvdp1 commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvdp1 Sep 11, 2022

Choose a reason for hiding this comment

Uh oh!

arteevraina Sep 11, 2022

Choose a reason for hiding this comment

Uh oh!

jvdp1 commented Sep 11, 2022

Uh oh!

arteevraina commented Sep 24, 2022

Uh oh!

zoziha commented Sep 24, 2022

Uh oh!

jvdp1 commented Sep 24, 2022

Uh oh!

jvdp1 commented Sep 25, 2022

Uh oh!

awvwgk Sep 25, 2022

Choose a reason for hiding this comment

Uh oh!

arteevraina Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arteevraina Oct 2, 2022

Choose a reason for hiding this comment

Uh oh!

jvdp1 Oct 3, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jvdp1 commented Sep 6, 2022 •

edited

Loading

arteevraina commented Sep 9, 2022 •

edited

Loading

jvdp1 commented Sep 9, 2022 •

edited

Loading

arteevraina Sep 26, 2022 •

edited

Loading