Skip to content

Dash mainnet readiness: embedded GBT + Phase C complete + interop fixes #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frstrtr wants to merge 223 commits into
base: master
Choose a base branch
from

Bug 14 fix: extend SML sync to (isValid, banHeight, revivedHeight) tr…

e691283
Select commit
Loading
Failed to load commit list.
Open

Dash mainnet readiness: embedded GBT + Phase C complete + interop fixes #43

Bug 14 fix: extend SML sync to (isValid, banHeight, revivedHeight) tr…
e691283
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed May 6, 2026 in 2s

41 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high
  • 1 medium

Other Alerts:

  • 16 warnings
  • 23 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 96 in test_dash_p2p.py

See this annotation in the file changed.

Code scanning / CodeQL

Binding a socket to all network interfaces Medium test

Binding a socket to all interfaces (using
'0.0.0.0'
Loading
) is a security risk.

Check notice on line 11 in test_dash_p2p.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note test

Import of 'sys' is not used.

Check notice on line 12 in test_dash_p2p.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note test

Import of 'time' is not used.

Check failure on line 2019 in src/impl/ltc/node.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Uncontrolled data used in path expression High

This argument to a file access function is derived from
user input (an environment variable)
Loading
and then passed to std::basic_ifstream<char, char_traits>::basic_ifstream(__s).
This argument to a file access function is derived from
user input (an environment variable)
Loading
and then passed to std::basic_ifstream<char, char_traits>::basic_ifstream(__s), which calls std::basic_ifstream<char, char_traits>::open(__s).
This argument to a file access function is derived from
user input (an environment variable)
Loading
and then passed to std::basic_ifstream<char, char_traits>::basic_ifstream(__s), which calls std::basic_ifstream<char, char_traits>::open(__s), which calls std::basic_filebuf<char, char_traits>::open(__s).

Check warning on line 877 in src/impl/ltc/share_tracker.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because budget_remaining >= 2.

Check warning on line 1638 in src/impl/ltc/node.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because my_payout <= 0.

Check warning on line 1614 in src/impl/ltc/node.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because total_recent <= 0.

Check warning on line 703 in src/core/web_server.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
Loading
may be assigned to a non-local variable.

Check warning on line 5539 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because overall_v36_votes <= 0.

Check warning on line 5520 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because overall_v36_votes <= 0.

Check warning on line 5479 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because sampling_total_weight <= 0.

Check warning on line 5456 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because overall_v36_shares <= 0 and 10 <= overall_total.

Check warning on line 5456 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always true because overall_total >= 10.

Check warning on line 5451 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always true because current_share_type <= 0.

Check warning on line 5435 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always true because overall_total >= 10.

Check warning on line 5434 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always true because overall_total >= 10.

Check warning on line 5120 in src/core/web_server.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because ... + ... <= 0.

Check warning on line 215 in src/c2pool/hashrate/tracker.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always true because denom_shares >= 1.

Check warning on line 5808 in src/c2pool/c2pool_refactored.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because total_rate <= 0.

Check warning on line 4866 in src/c2pool/c2pool_refactored.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because total_rate <= 0.

Check notice on line 766 in src/c2pool/c2pool_refactored.cpp

See this annotation in the file changed.

Code scanning / CodeQL

For loop variable changed in body Note

Loop counters should not be modified in the body of the
loop
Loading
.

Check notice on line 2564 in src/impl/ltc/share_tracker.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable it2 is not used.

Check notice on line 2557 in src/impl/ltc/share_tracker.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable it is not used.

Check notice on line 1645 in src/impl/ltc/share_tracker.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable share_period is not used.

Check notice on line 1216 in src/impl/ltc/share_tracker.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable gens is not used.