Update client-api dependencies, bump openapi-fetch to 0.17, add CI#22169
Update client-api dependencies, bump openapi-fetch to 0.17, add CI#22169dannon merged 5 commits intogalaxyproject:devfrom
Conversation
Update all client-api package dependencies within semver ranges, resolving security vulnerabilities in transitive deps (undici, glob, vite, rollup, minimatch, brace-expansion).
No breaking API changes from 0.15→0.17, just additive features (custom path serializers, read/write markers). Two type-level fixes needed where openapi-fetch 0.17 widens tuple types like [string, string][] to string[][] in inferred response types.
Runs build and tests on changes to client-api/ or client/src/api/ (the symlinked types). Installs client deps first since client-api's type symlink depends on the client's tsconfig resolution.
Aligns with the main client's recent migration to pnpm. Drops package-lock.json in favor of pnpm-lock.yaml and updates CI workflows (client-api-test, publish_artifacts) accordingly.
dannon
changed the title
|
Re: the type casts -- confirmed it's a genuine bug in openapi-typescript-helpers 0.1.0 (bundled with openapi-fetch 0.17). The new Upstream bug: openapi-ts/openapi-typescript#2632 Added comments referencing the issue at both cast sites so they're easy to find and remove later. |
Reference upstream bug (openapi-ts/openapi-typescript#2632) at both cast sites so they're easy to find and remove once the Readable<T> tuple widening fix lands.
davelopez
left a comment
davelopez
left a comment
There was a problem hiding this comment.
Thanks for checking the casts!
|
Failed job is just stale cache; saving the CI here and merging it. Thank you for the review @davelopez ! |
github-project-automation
bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
3 participants
Summary
client-apitransitive dependencies, resolving security vulnerabilities in the lockfileopenapi-fetchfrom^0.15.0to^0.17.0in bothclient/andclient-api/, keeping them aligned. No breaking API changes from 0.15→0.17 (just additive features: custom path serializers, read/write markers). Two type-level fixes where 0.17 widens tuple types like[string, string][]tostring[][]in inferred response types.client-api-test.yamlCI workflow that builds and tests the client-api package on changes toclient-api/orclient/src/api/client-apifrom npm to pnpm to match the main client's recent migration. Dropspackage-lock.json, updates CI workflows accordingly.Supersedes #21313, #21121, #22143.
Test plan
cd client-api && pnpm run build— ESM+CJS build succeedscd client-api && pnpm test— 9/9 tests passcd client && pnpm test— 310 files, 1763 tests passcd client && npx vue-tsc --noEmit— clean, 0 type errors