Skip to content

Feature/improve ci#2328

Open
GCHQDeveloper581 wants to merge 4 commits intogchq:masterfrom
GCHQDeveloper581:feature/improve-ci
Open

Feature/improve ci#2328
GCHQDeveloper581 wants to merge 4 commits intogchq:masterfrom
GCHQDeveloper581:feature/improve-ci

Conversation

@GCHQDeveloper581
Copy link
Copy Markdown
Contributor

Description
Some performance/usability/security improvements to the pull_request workflow script

  • Use 'npm ci' rather than 'npm install' to prevent updates being pulled in when doing the CI run/build
    • prevents package-lock.json being modified mid-build
    • increases consistency of builds
    • reduces the risk of unintentionally pulling in malicious updates
  • move UI tests before production image build
    • UI tests don't require the docker image(s), and doing the testing first reduces the time till testing is complete and hence time-to-failure in the event of a bad tree
  • save artefact from build
    • allows the built code to be tested locally without having to do a local build

AI disclosure
No use of AI

Test Coverage
N/A

@GCHQDeveloper581 GCHQDeveloper581 marked this pull request as ready for review April 18, 2026 10:47
@GCHQDeveloper581 GCHQDeveloper581 requested a review from C85297 April 18, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant