Skip to content

Feature/improve ci #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GCHQDeveloper581 merged 4 commits into from
Apr 20, 2026
+17 −10
Merged

Feature/improve ci #2328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
beaec4e
Use "npm ci" rather than "npm install" to prevent updates during CI
GCHQDeveloper581 Apr 18, 2026
dc6a345
Move UI tests before docker image build to reduce time-to-failure
GCHQDeveloper581 Apr 18, 2026
44919ac
Save zipped build as an artefact
GCHQDeveloper581 Apr 18, 2026
6101959
Replay updates into the releases and master workflows
GCHQDeveloper581 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ jobs:

- name: Install
run: |
export DETECT_CHROMEDRIVER_VERSION=true
npm install
npm ci
npm run setheapsize

- name: Lint
Expand Down
23 changes: 16 additions & 7 deletions .github/workflows/pull_requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ jobs:

- name: Install
run: |
export DETECT_CHROMEDRIVER_VERSION=true
npm install
npm ci
npm run setheapsize

- name: Lint
Expand All @@ -38,7 +37,22 @@ jobs:
if: success()
run: npx grunt prod

- name: Upload Build Artefact
if: success()
uses: actions/upload-artifact@v7
with:
name: zipped-build
path: build/prod/*.zip
retention-days: 5

- name: UI Tests
if: success()
run: |
sudo apt-get install xvfb
xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui

- name: Set up Docker Buildx
if: success()
uses: docker/setup-buildx-action@v3

- name: Set up QEMU
Expand All @@ -50,8 +64,3 @@ jobs:
uses: docker/build-push-action@v6
with:
platforms: linux/amd64,linux/arm64
- name: UI Tests
if: success()
run: |
sudo apt-get install xvfb
xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
1 change: 0 additions & 1 deletion .github/workflows/releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:

- name: Install
run: |
export DETECT_CHROMEDRIVER_VERSION=true
npm ci
npm run setheapsize

Expand Down
Loading