feat(GiniHealthSDK): Add customizable navigation bar title to Payment Review Screen#1184
Open
zladzeyka wants to merge 1 commit into
Open
feat(GiniHealthSDK): Add customizable navigation bar title to Payment Review Screen#1184zladzeyka wants to merge 1 commit into
zladzeyka wants to merge 1 commit into
Conversation
… Review Screen Customers can override "gini.health.reviewscreen.title" in their own Localizable.strings to set a navigation bar title. Defaults to empty to preserve existing behavior for all current integrations. HEAL-514
zladzeyka
requested a deployment
to
firebase-manual-deploy
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
HEAL-514
Adds a localizable navigation bar title to the Payment Review Screen so customers can customize it in their own
Localizable.strings.In v6.0.0 the close button moved into the navigation bar, requiring customers like IBM to show the nav bar. Previously there was no way to set a title, leaving it empty. A new string key
gini.health.reviewscreen.titledefaults to empty (preserving existing behavior) and can be overridden by the host app.Changes span two modules:
GiniInternalPaymentSDKreceives the newpaymentReviewScreenTitleproperty onPaymentReviewStringsand the updatedsetupNavigationBar()logic;GiniHealthSDKowns the localization key and wires it through the strings provider.Notes for Reviewers
To verify the default (empty title) behavior is unchanged: run the GiniHealthSDK example app in
documentCollectiondisplay mode — the nav bar title should remain blank.To verify the customization: add
"gini.health.reviewscreen.title" = "Payment Review";to the host app'sLocalizable.stringsand re-run — the nav bar should show the custom title.The title is set unconditionally for
documentCollectionmode, independently of theshowPaymentReviewCloseButtonflag, so it works whether or not the close button is shown.No unit tests added — the change is a pass-through from localization to
navigationItem.titlewith no logic to test.