Skip to content

feat(GiniHealthSDK): Add customizable navigation bar title to Payment Review Screen #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zladzeyka wants to merge 1 commit into
base: release/liquid_glass_health_sdk
Choose a base branch
from
Open

feat(GiniHealthSDK): Add customizable navigation bar title to Payment Review Screen #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...lPaymentSDK/Sources/GiniInternalPaymentSDK/PaymentReview/PaymentReviewConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public struct PaymentReviewStrings {
public let closeButtonAccessibilityHint: String
public let sheetGrabberAccessibilityLabel: String
public let sheetGrabberAccessibilityHint: String
public let paymentReviewScreenTitle: String

public init(alertOkButtonTitle: String,
infoBarMessage: String,
Expand All @@ -75,7 +76,8 @@ public struct PaymentReviewStrings {
closeButtonAccessibilityLabel: String,
closeButtonAccessibilityHint: String,
sheetGrabberAccessibilityLabel: String,
sheetGrabberAccessibilityHint: String) {
sheetGrabberAccessibilityHint: String,
paymentReviewScreenTitle: String) {
self.alertOkButtonTitle = alertOkButtonTitle
self.infoBarMessage = infoBarMessage
self.defaultErrorMessage = defaultErrorMessage
Expand All @@ -85,5 +87,6 @@ public struct PaymentReviewStrings {
self.closeButtonAccessibilityHint = closeButtonAccessibilityHint
self.sheetGrabberAccessibilityLabel = sheetGrabberAccessibilityLabel
self.sheetGrabberAccessibilityHint = sheetGrabberAccessibilityHint
self.paymentReviewScreenTitle = paymentReviewScreenTitle
}
}
12 changes: 7 additions & 5 deletions ...PaymentSDK/Sources/GiniInternalPaymentSDK/PaymentReview/PaymentReviewViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,19 @@ public final class PaymentReviewViewController: UIHostingController<PaymentRevie
}

private func setupNavigationBar() {
guard model.showPaymentReviewCloseButton,
model.displayMode == .documentCollection else { return }

guard model.displayMode == .documentCollection else { return }

navigationItem.title = model.strings.paymentReviewScreenTitle

guard model.showPaymentReviewCloseButton else { return }

let closeImage = model.configuration.paymentReviewClose.withRenderingMode(.alwaysTemplate)
let closeButton = UIBarButtonItem(image: closeImage,
style: .plain,
target: self,
action: #selector(closeButtonTapped))

closeButton.accessibilityLabel = model.strings.closeButtonAccessibilityLabel
closeButton.accessibilityHint = model.strings.closeButtonAccessibilityHint
closeButton.accessibilityHint = model.strings.closeButtonAccessibilityHint
navigationItem.rightBarButtonItem = closeButton
}

Expand Down
4 changes: 3 additions & 1 deletion ...iniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth+PaymentComponentsStringsProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ extension GiniHealth: PaymentComponentsStringsProvider {
sheetGrabberAccessibilityLabel: NSLocalizedStringPreferredFormat("gini.health.bottomSheet.grabber.accessibility.label",
comment: "Sheet grabber accessibility label"),
sheetGrabberAccessibilityHint: NSLocalizedStringPreferredFormat("gini.health.bottomSheet.grabber.accessibility.hint",
comment: "Sheet grabber accessibility hint text")
comment: "Sheet grabber accessibility hint text"),
paymentReviewScreenTitle: NSLocalizedStringPreferredFormat("gini.health.reviewscreen.title",
comment: "navigation bar title for payment review screen")
)
}

Expand Down
1 change: 1 addition & 0 deletions HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Resources/de.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// Copyright © 2024 Gini GmbH. All rights reserved.

*/
"gini.health.reviewscreen.title" = "";
"gini.health.alert.ok.title" = "OK";
"gini.health.close.button.accessibility.label" = "Schließen";
"gini.health.close.button.accessibility.hint" = "Tippen zum Schließen";
Expand Down
1 change: 1 addition & 0 deletions HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Resources/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// Copyright © 2024 Gini GmbH. All rights reserved.

*/
"gini.health.reviewscreen.title" = "";
"gini.health.reviewscreen.recipient.placeholder" = "Recipient";
"gini.health.reviewscreen.iban.placeholder" = "IBAN";
"gini.health.reviewscreen.amount.placeholder" = "Amount";
Expand Down
Loading