Eliminate chip rendering duplication in SInputDropdown inline search#666
Merged
Conversation
…d to array Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on inline search functionality
Eliminate chip rendering duplication in SInputDropdown inline search
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code duplication between array and single-value chip rendering in the inline search feature (lines 391-440). The two template blocks were nearly identical, differing only in iteration and variable naming.
Changes:
selectedChipscomputed property that normalizes both single and array values to always return an array, eliminating the need for separate rendering logicv-forloop that handles both single-select and multi-select modesBefore:
After:
Reduces code by ~40 lines while preserving all functionality.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.