Skip to content

Eliminate chip rendering duplication in SInputDropdown inline search #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brc-dd merged 2 commits into from
Dec 8, 2025
Merged

Eliminate chip rendering duplication in SInputDropdown inline search #666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9400786
Initial plan
Copilot Dec 8, 2025
4088546
Refactor: eliminate chip rendering duplication by normalizing selecte…
Copilot Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 33 additions & 50 deletions lib/components/SInputDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ const removable = computed(() => {
return !!props.nullable
})

const selectedChips = computed(() => {
if (Array.isArray(selected.value)) {
return selected.value
}

return selected.value ? [selected.value] : []
})

const ariaActiveDescendant = computed(() => {
if (!isInlineSearch.value || !inlineActiveOption.value) {
return undefined
Expand Down Expand Up @@ -388,57 +396,32 @@ function focusInlineInput() {
>
<div class="box-content" :class="{ inline: isInlineSearch }">
<template v-if="isInlineSearch">
<template v-if="Array.isArray(selected)">
<div
v-for="(item, i) in selected"
:key="item.value ?? i"
class="inline-chip"
:class="{ avatar: item.type === 'avatar' }"
<div
v-for="(item, i) in selectedChips"
:key="item.value ?? i"
class="inline-chip"
:class="{ avatar: item.type === 'avatar' }"
>
<template v-if="item.type === 'avatar'">
<div class="inline-chip-avatar">
<SAvatar size="fill" :avatar="item.image" />
</div>
<div class="inline-chip-label">{{ item.label }}</div>
</template>
<template v-else>
<div class="inline-chip-label">{{ item.label }}</div>
</template>
<button
v-if="removable"
type="button"
class="inline-chip-close"
:aria-label="`${t.remove} ${item.label}`"
:disabled="disabled ?? false"
@click.stop="handleSelect(item.value)"
>
<template v-if="item.type === 'avatar'">
<div class="inline-chip-avatar">
<SAvatar size="fill" :avatar="item.image" />
</div>
<div class="inline-chip-label">{{ item.label }}</div>
</template>
<template v-else>
<div class="inline-chip-label">{{ item.label }}</div>
</template>
<button
v-if="removable"
type="button"
class="inline-chip-close"
:aria-label="`${t.remove} ${item.label}`"
:disabled="disabled ?? false"
@click.stop="handleSelect(item.value)"
>
<IconX class="inline-chip-close-icon" />
</button>
</div>
</template>
<template v-else-if="selected">
<div class="inline-chip" :class="{ avatar: selected.type === 'avatar' }">
<template v-if="selected.type === 'avatar'">
<div class="inline-chip-avatar">
<SAvatar size="fill" :avatar="selected.image" />
</div>
<div class="inline-chip-label">{{ selected.label }}</div>
</template>
<template v-else>
<div class="inline-chip-label">{{ selected.label }}</div>
</template>
<button
v-if="removable"
type="button"
class="inline-chip-close"
:aria-label="`${t.remove} ${selected.label}`"
:disabled="disabled ?? false"
@click.stop="handleSelect(selected.value)"
>
<IconX class="inline-chip-close-icon" />
</button>
</div>
</template>
<IconX class="inline-chip-close-icon" />
</button>
</div>

<input
ref="inlineInput"
Expand Down