ci(gnovm): skip print-only coverage instrumentation#5815
Draft
thehowl wants to merge 2 commits into
Draft
Conversation
Since #5795 the per-module coverage percentages are only printed to the job log; nothing uploads or tracks them. The instrumentation costs a measured ~1.24x on the gnovm interpreter-heavy tests (TestStdlibs/sort: 22.1s -> 27.5s) plus an instrumented rebuild of every package. Add a 'coverage' input to the reusable Go CI workflow (default true, so gno.land/tm2/misc/contribs keep their current behavior) and opt gnovm out of it.
The coverage dir env vars (TXTARCOVERDIR, GOCOVERDIR, COVERDIR) also steer testscript-based suites: cmd/gno's Test_Scripts fails when TXTARCOVERDIR points at a directory that was never created. With coverage off, leave them empty so those suites skip coverage collection, matching a plain local run.
This was referenced Jun 11, 2026
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Part 5 of 6 of the gnovm performance stack (split from #5800), to be merged in order:
Each PR is based on the previous one's branch; this one diffs against part 4. Together:
ci / gnovm~14m → 6m18s;pkg/gnolangtest time −64%; VM heap allocations −84% on the heaviest suite.Summary
Since #5795 the per-module coverage percentages are only printed to the job log; nothing uploads or tracks them. On gnovm the instrumentation costs a measured ~1.24x on the interpreter-heavy tests (
TestStdlibs/sort: 22.1s → 27.5s) plus an instrumented rebuild of every package — with-coverpkg=gnovm/...the interpreter hot loop itself is instrumented while it interprets the test workloads.This adds a
coverageinput to the reusable Go CI workflow (defaulttrue, so gno.land/tm2/misc/contribs keep their current behavior) and opts gnovm out of it. With coverage off, the coverage dir env vars are left unset so testscript-based suites (cmd/gno, gno.land integration) skip coverage collection too, matching a plain local run.Measurements
4-core CI simulation of
pkg/gnolangwith the gnovm CI configuration: 424.9s (with coverage) → 273.4s (without). On CI this is the difference betweenpkg/gnolangat ~630–940s and ~256–390s.