Skip to content

ci(gnovm): skip print-only coverage instrumentation #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thehowl wants to merge 2 commits into
base: dev/morgan/gnovm-iface-array-share
Choose a base branch
from
+23 −4
Draft

ci(gnovm): skip print-only coverage instrumentation #5815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3c3cf
ci(gnovm): skip print-only coverage instrumentation
thehowl Jun 11, 2026
56decad
ci: leave coverage env vars unset when coverage is off
thehowl Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions .github/workflows/_ci-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ on:
required: false
type: string
default: ""
coverage:
description: "Collect coverage and print per-module percentages (the data is not uploaded anywhere; see #5795). Instrumentation slows interpreter-heavy tests measurably."
required: false
type: boolean
default: true

permissions: {}

Expand Down Expand Up @@ -85,14 +90,25 @@ jobs:
working-directory: ${{ inputs.modulepath }}
env:
SEQ_TS: ${{ inputs.tests-ts-seq }}
TXTARCOVERDIR: /tmp/txtarcoverdir
GOCOVERDIR: /tmp/gocoverdir
COVERDIR: /tmp/coverdir
# The coverage dir env vars also steer testscript-based suites
# (cmd/gno, gno.land integration): leave them unset without
# coverage so those suites skip coverage collection too.
TXTARCOVERDIR: ${{ inputs.coverage && '/tmp/txtarcoverdir' || '' }}
GOCOVERDIR: ${{ inputs.coverage && '/tmp/gocoverdir' || '' }}
COVERDIR: ${{ inputs.coverage && '/tmp/coverdir' || '' }}
INPUTS_MODULEPATH: ${{ inputs.modulepath }}
INPUTS_TESTS_EXTRA_ARGS: ${{ inputs.tests-extra-args }}
INPUTS_COVERAGE: ${{ inputs.coverage }}
run: |
set -x

if [ "$INPUTS_COVERAGE" != "true" ]; then
# INPUTS_TESTS_EXTRA_ARGS must word-split into flags
# shellcheck disable=SC2086
go test -timeout 30m ${INPUTS_TESTS_EXTRA_ARGS} ./...
exit 0
fi

mkdir -p "$GOCOVERDIR" "$TXTARCOVERDIR" "$COVERDIR"

export filter="-pkg=github.com/gnolang/gno/${INPUTS_MODULEPATH}/..."
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/ci-dir-gnovm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ jobs:
uses: ./.github/workflows/_ci-go.yml
with:
modulepath: "gnovm"
tests-extra-args: "-coverpkg=github.com/gnolang/gno/gnovm/..."
# Coverage instrumentation costs ~1.24x on the interpreter-heavy
# tests, and since #5795 the percentages are only printed to the
# job log; skip it on gnovm's critical path.
coverage: false
stdlibs:
uses: ./.github/workflows/_ci-gno.yml
with:
Expand Down
Loading