Avoiding grep

[hemanth]

^ //cc @addyosmani

[brokerUA]

Yes, it's good fix for Windows users, because 'grep' return error.

[Garbee]

Will [[ -z $(git status -s) ]] even run on Windows?

[hemanth]

Why wouldn't it? It's a standard bash expression.

[Garbee]

Windows doesn't have Bash by default.

[hemanth]

It doesn't have grep either...

[mh-cbon]

Will [[ -z $(git status -s) ]] even run on Windows?

wrap it in a node script. should be about 10 lines most, if such module does not exist yet.

[brokerUA]

Maybe need check installed bush ( and git) before run commands.
Something like for %i in (git.exe) do ... (Windows cmd is not my specialization)

I just removed grep and install GIT for Windows:
gulp && git status || (echo 'Please commit all changes generated by building'; exit 1)

[Garbee]

I'm not saying the existing command is perfection. However moving forward we should make sure changes to the pipeline work across platforms.

I just removed grep and install GIT for Windows:gulp && git status || (echo 'Please commit all changes generated by building'; exit 1)

This will fail most likely. As git status with all being fine will output On branch master nothing to commit, working tree clean. Which is what we want, however no scenario will cause the or check to exit with a status code of 1 to ever trigger.

[mh-cbon]

+/- this (abused the one liner)

node -e 'require("child_process").spawn("git", ["status"]).stdout.on("data", function(){process.exit(1);});' && echo "ok"