Skip to content

fix: allow read_mask on standard method requests#1624

Open
MukundaKatta wants to merge 1 commit into
googleapis:mainfrom
MukundaKatta:codex/aip-standard-read-mask
Open

fix: allow read_mask on standard method requests#1624
MukundaKatta wants to merge 1 commit into
googleapis:mainfrom
MukundaKatta:codex/aip-standard-read-mask

Conversation

@MukundaKatta
Copy link
Copy Markdown

Fixes #1128.

This updates the standard method request unknown-field rules so AIP-157 read_mask request fields are accepted consistently beyond Get/List:

  • allow read_mask on Create requests
  • allow read_mask on Update requests
  • allow read_mask on Delete requests
  • add focused rule tests for each method family

Validation:

  • gofmt
  • GOCACHE=/Users/ubl/Documents/New project/oss-contributions/api-linter/.gocache GOMODCACHE=/Users/ubl/Documents/New project/oss-contributions/api-linter/.gomodcache go test ./rules/aip0133 ./rules/aip0134 ./rules/aip0135

@MukundaKatta MukundaKatta requested a review from a team as a code owner April 30, 2026 23:33
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the linting rules for AIP-0133 (Create), AIP-0134 (Update), and AIP-0135 (Delete) to include "read_mask" as an allowed field, as per AIP-157. Corresponding test cases and proto imports were also added to verify the changes. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allowlist "standard fields" for all request-unknown-fields rules

1 participant