Skip to content

fix: allow read_mask on standard method requests #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MukundaKatta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow read_mask on standard method requests #1624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rules/aip0133/request_unknown_fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var unknownFields = &lint.MessageRule{
// Rule check: Establish that there are no unexpected fields.
allowedFields := stringset.New(
"parent", // AIP-133
"read_mask", // AIP-157
"request_id", // AIP-155
"validate_only", // AIP-163
"view", // AIP-157
Expand Down
9 changes: 9 additions & 0 deletions rules/aip0133/request_unknown_fields_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ func TestUnknownFields(t *testing.T) {
testutils.Problems{},
"",
},
{
"ReadMaskField",
"CreateBookRequest",
"read_mask",
"google.protobuf.FieldMask",
testutils.Problems{},
"",
},
{
"ViewField",
"CreateBookRequest",
Expand Down Expand Up @@ -117,6 +125,7 @@ func TestUnknownFields(t *testing.T) {
for _, test := range tests {
t.Run(test.testName, func(t *testing.T) {
f := testutils.ParseProto3Tmpl(t, `
import "google/protobuf/field_mask.proto";
enum BookView {
BOOK_VIEW_UNSPECIFIED = 0;
BOOK_VIEW_BASIC = 1;
Expand Down
1 change: 1 addition & 0 deletions rules/aip0134/request_unknown_fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var unknownFields = &lint.MessageRule{
allowedFields := stringset.New(
fieldNameFromResource(resource), // AIP-134
"allow_missing", // AIP-134
"read_mask", // AIP-157
"request_id", // AIP-155
"update_mask", // AIP-134
"validate_only", // AIP-163
Expand Down
5 changes: 5 additions & 0 deletions rules/aip0134/request_unknown_fields_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ func TestUnknownFields(t *testing.T) {
"google.protobuf.FieldMask",
testutils.Problems{},
},
{
"ReadMask", "UpdateBigBookRequest", "read_mask",
"google.protobuf.FieldMask",
testutils.Problems{},
},
{
"ValidateOnly", "UpdateBigBookRequest", "validate_only",
"bool",
Expand Down
1 change: 1 addition & 0 deletions rules/aip0135/request_unknown_fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var unknownFields = &lint.MessageRule{
"force": {}, // AIP-135
"allow_missing": {}, // AIP-135
"etag": {}, // AIP-154
"read_mask": {}, // AIP-157
"request_id": {}, // AIP-155
"validate_only": {}, // AIP-163
"view": {}, // AIP-157
Expand Down
2 changes: 2 additions & 0 deletions rules/aip0135/request_unknown_fields_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func TestUnknownFields(t *testing.T) {
{"Force", "DeleteBookRequest", "force", "bool", testutils.Problems{}},
{"Etag", "DeleteBookRequest", "etag", "string", testutils.Problems{}},
{"AllowMissing", "DeleteBookRequest", "allow_missing", "bool", testutils.Problems{}},
{"ReadMask", "DeleteBookRequest", "read_mask", "google.protobuf.FieldMask", testutils.Problems{}},
{"RequestId", "DeleteBookRequest", "request_id", "string", testutils.Problems{}},
{"ValidateOnly", "DeleteBookRequest", "validate_only", "bool", testutils.Problems{}},
{"ValidView", "DeleteBookRequest", "view", "BookView", testutils.Problems{}},
Expand All @@ -45,6 +46,7 @@ func TestUnknownFields(t *testing.T) {
for _, test := range tests {
t.Run(test.testName, func(t *testing.T) {
f := testutils.ParseProto3Tmpl(t, `
import "google/protobuf/field_mask.proto";
enum BookView {
BOOK_VIEW_UNSPECIFIED = 0;
BOOK_VIEW_BASIC = 1;
Expand Down