FE-809: Project-graph review-set proposal and atomic acceptance by lunelson · Pull Request #175 · hashintel/brunch

lunelson · 2026-06-05T09:45:13Z

Stack Context

This stack prepares the Brunch POC live-ship path: FE-807 makes structured-exchange answers graph-native for the selected spec, FE-809 layers user-reviewed project-graph batch commits, and FE-811 closes the live-ship gate/runbook blockers above it.

What?

Wires the real project-graph strategy through dry-run-gated present_review_set / request_review structured exchange payloads.
Accepts approvals through public session.submitExchangeResponse instead of a bypass path.
Commits the exact reviewed batch through CommandExecutor.acceptReviewSet as one explicit-basis graph batch, one LSN, and one change-log entry.
Publishes graph/session invalidations with { specId, lsn } and includes the real probe fixture evidence.

Why?

The POC needs a reviewable batch-commit story without inventing a standalone review-set entity or allowing partial/manual acceptance. This PR keeps D27-L structured-exchange ownership and D4-L/D20-L single mutation authority intact while making approval observable by web/TUI paths.

Verification

src/.pi/agents/state.test.ts
src/.pi/__tests__/prompting.test.ts
src/probes/project-graph-review-cycle-proof.test.ts
.fixtures/runs/project-graph-review-cycle/2026-06-06-project-graph-review-cycle/

lunelson · 2026-06-05T09:45:39Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor · 2026-06-06T16:45:19Z

PR Summary

Low Risk
Fixture and documentation only; no product code paths changed in this diff.

Overview
Adds FE-809 probe run artifacts under .fixtures/runs/project-graph-review-cycle/2026-06-06-project-graph-review-cycle/ and indexes that run in .fixtures/README.md.

The captured run documents a successful project-graph tracer: seed macro-view-grounded-intent, read_graph → present_review_set (after schema retries), external request_review approval, and explicit-basis readback (+2 nodes, +4 edges, LSN 3→4). Bundled artifacts are report.json, session.jsonl, transcript.md, and graph-snapshot.json for regression and human review—not application runtime changes in this diff.

^{Reviewed by Cursor Bugbot for commit d0b6617. Bugbot is set up for automated code reviews on this repo. Configure here.}

Copilot

Pull request overview

This PR advances the D52-L topology shift by introducing explicit projections/ and renderers/ seams, migrating structured-exchange and transcript formatting to those seams, and hardening graph storage invariants by making the graph clock/change-log spec-scoped. It also updates the Vite web build to include Tailwind and refreshes the Pi harness extension layout and resource manifests.

Changes:

Introduces src/projections/ (DTO projection) and src/renderers/ (lossy text/markdown) and migrates prior */project and */format responsibilities into them.
Makes graph_clock and change_log spec-scoped (spec_id keyed) with a migration + snapshot/test updates to ensure LSN correctness per spec.
Refactors Pi structured-exchange tooling to use Zod-authored schemas + projector/renderers, adds present_review_set/request_review, and updates the web shell (Tailwind + layout tweaks).

Reviewed changes

Copilot reviewed 214 out of 250 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
vite.config.ts	Enable Tailwind Vite plugin
src/workspace/README.md	Add workspace topology README
src/workspace/package-identity.test.ts	Fix repo-root resolution
src/web/vite-env.d.ts	Add Vite client types
src/web/styles.css	Add Tailwind v4 theme/base
src/web/routes/spec.tsx	Tailwind layout/styling updates
src/web/queries/workspace.ts	Import projection snapshot type
src/web/queries/session.ts	Import projection runtime type
src/web/main.tsx	Load global styles
src/web/app.test.tsx	Update snapshot type import
src/structured-exchange/project/request-review.ts	Remove retired stub module
src/structured-exchange/project/request-choices.ts	Remove retired stub module
src/structured-exchange/project/request-choice.ts	Remove retired stub module
src/structured-exchange/project/request-answer.ts	Remove retired stub module
src/structured-exchange/project/present-review-set.ts	Remove retired stub module
src/structured-exchange/project/present-question.ts	Remove legacy projector (moved)
src/structured-exchange/project/present-options.ts	Remove retired stub module
src/structured-exchange/format/request-review.ts	Remove retired stub module
src/structured-exchange/format/request-choices.ts	Remove retired stub module
src/structured-exchange/format/request-choice.ts	Remove retired stub module
src/structured-exchange/format/request-answer.ts	Remove retired stub module
src/structured-exchange/format/present-review-set.ts	Remove retired stub module
src/structured-exchange/format/present-options.ts	Remove retired stub module
src/session/workspace-session-coordinator/boot-session-store.ts	Rename default spec option
src/session/structured-exchange.ts	Remove legacy details model
src/session/session-transcript.ts	Point at projections/renderers
src/session/session-transcript.test.ts	Update details shape assertions
src/session/runtime-state.test.ts	Import projected runtime state
src/session/README.md	Update ownership/topology notes
src/session/exchange-projection.ts	Use new exchange details schema
src/scripts/README.md	Add scripts topology README
src/rpc/README.md	Document review submission semantics
src/rpc/methods/workspace.ts	Use workspace snapshot projector
src/renderers/workspace/workspace-snapshot.ts	New workspace snapshot renderer
src/renderers/workspace/workspace-snapshot.test.ts	Move print snapshot tests
src/renderers/toon.ts	Update future-caller comment
src/renderers/structured-exchange/request-review.ts	New request_review renderer
src/renderers/structured-exchange/request-choices.ts	New request_choices renderer
src/renderers/structured-exchange/request-choice.ts	New request_choice renderer
src/renderers/structured-exchange/request-answer.ts	New request_answer renderer
src/renderers/structured-exchange/present-review-set.ts	New review-set renderer
src/renderers/structured-exchange/present-question.ts	Repoint to projections/renderers
src/renderers/structured-exchange/present-options.ts	New present_options renderer
src/renderers/structured-exchange/present-candidates.ts	Update projector path comment
src/renderers/structured-exchange/capture-review.ts	Update projector path comment
src/renderers/structured-exchange/capture-choices.ts	Update projector path comment
src/renderers/structured-exchange/capture-choice.ts	Update projector path comment
src/renderers/structured-exchange/capture-candidate.ts	Update projector path comment
src/renderers/structured-exchange/capture-answer.ts	Update projector path comment
src/renderers/session/transcript.ts	Repoint to projections
src/renderers/README.md	Add renderer topology README
src/renderers/markdown.ts	Update future-caller comment
src/renderers/graph/reconciliation-needs.ts	Update projector path comment
src/renderers/graph/overview.ts	Update projector path comment
src/renderers/graph/neighborhood.ts	Repoint imports to projections
src/renderers/graph/commit-result.ts	Update projector path comment
src/README.md	Update src/ topology contract
src/projections/workspace/workspace-snapshot.ts	Move renderer out to renderers/
src/projections/topology-boundaries.test.ts	Add topology boundary tests
src/projections/structured-exchange/review-set-payload.ts	Translate review-set details
src/projections/structured-exchange/request-review.ts	New request_review projector
src/projections/structured-exchange/request-choices.ts	New request_choices projector
src/projections/structured-exchange/request-choice.ts	New request_choice projector
src/projections/structured-exchange/request-answer.ts	New request_answer projector
src/projections/structured-exchange/present-review-set.ts	New present_review_set projector
src/projections/structured-exchange/present-question.ts	New present_question projector
src/projections/structured-exchange/present-options.ts	New present_options projector
src/projections/structured-exchange/present-candidates.ts	Update future-caller comment
src/projections/structured-exchange/capture-review.ts	Update future-caller comment
src/projections/structured-exchange/capture-choices.ts	Update future-caller comment
src/projections/structured-exchange/capture-choice.ts	Update future-caller comment
src/projections/structured-exchange/capture-candidate.ts	Update future-caller comment
src/projections/structured-exchange/capture-answer.ts	Update future-caller comment
src/projections/session/transcript-context.ts	Update renderer path comment
src/projections/session/runtime-policy.ts	New runtime policy definitions
src/projections/README.md	Add projections topology README
src/projections/graph/reconciliation-needs.ts	Update renderer path comment
src/projections/graph/overview.ts	Update renderer path comment
src/projections/graph/neighborhood.ts	Update import paths to graph/
src/projections/graph/commit-result.ts	Update renderer path comment
src/probes/structured-exchange-rpc-proof.ts	Update exchange type import
src/probes/structured-exchange-rpc-proof.test.ts	Update expected request details
src/probes/structured-exchange-ordering-proof.ts	Update exchange adapter import
src/probes/structured-exchange-ordering-proof.test.ts	Update expected details fields
src/probes/scripts/verify-startup-no-resume.sh	Update dist entry path
src/probes/public-rpc-parity-proof.ts	Update details field names
src/probes/propose-graph-commit-proof.ts	Update TUI entry imports
src/probes/fixture-curation-loop.ts	Update TUI entry imports
src/graph/snapshot.ts	Scope graph clock by spec
src/graph/snapshot.test.ts	Seed per-spec graph clock rows
src/graph/seed-fixtures.test.ts	Assert spec-scoped clock/log
src/graph/README.md	Document spec-local clock/audit
src/graph/index.ts	Export review-set translation APIs
src/graph/export-fixtures.test.ts	New fixture export tests
src/graph/command-executor/commit-graph-batch.test.ts	Spec-scoped clock assertions
src/db/schema.ts	Spec-scoped graph_clock/change_log
src/db/README.md	Update DB migration expectations
src/app/README.md	Add app topology README
src/app/brunch.ts	Move CLI entry to app/
src/app/brunch.test.ts	Fix imports after app move
src/app/brunch.smoke.test.ts	Add pi-coding-agent smoke
src/app/brunch-tui.ts	Repoint to new .pi shells
src/.pi/skills/strategies/step-wise-disambiguate.md	Add strategy resource
src/.pi/skills/strategies/step-wise-decision-tree.md	Add strategy resource
src/.pi/skills/strategies/README.md	Add strategies README
src/.pi/skills/strategies/propose-graph.md	Add strategy resource
src/.pi/skills/strategies/project-graph.md	Add strategy resource
src/.pi/skills/README.md	Add skills topology README
src/.pi/skills/methods/run-structured-exchange.md	Add method resource
src/.pi/skills/methods/review-for-gaps.md	Add method resource
src/.pi/skills/methods/read-snapshot.md	Add method resource
src/.pi/skills/methods/infer-and-capture.md	Add method resource
src/.pi/skills/methods/generate-proposal.md	Add method resource
src/.pi/skills/methods/commit-graph.md	Add method resource
src/.pi/skills/lenses/README.md	Add lenses README
src/.pi/skills/lenses/oracle.md	Add lens resource
src/.pi/skills/lenses/intent.md	Add lens resource
src/.pi/skills/lenses/design.md	Add lens resource
src/.pi/skills/goals/grounding-advance.md	Add goal resource
src/.pi/skills/goals/elicit-expand.md	Add goal resource
src/.pi/skills/goals/commit-converge.md	Add goal resource
src/.pi/skills/goals/capture-posture.md	Add goal resource
src/.pi/settings.json	Update extension entrypoints
src/.pi/README.md	Rewrite .pi topology README
src/.pi/extensions/workspace/index.ts	Fix imports after moves
src/.pi/extensions/system-prompts/index.ts	Use runtime policy projection
src/.pi/extensions/structured-exchange/shared/recovery.ts	Remove legacy recovery code
src/.pi/extensions/structured-exchange/shared/model.ts	Remove legacy model types
src/.pi/extensions/structured-exchange/request-review.ts	Remove stubbed tool
src/.pi/extensions/structured-exchange/request-answer.ts	Remove legacy request tool
src/.pi/extensions/structured-exchange/present-review-set.ts	Remove stubbed tool
src/.pi/extensions/structured-exchange/present-options.ts	Remove legacy present tool
src/.pi/extensions/session/lifecycle.ts	New session boundary hook
src/.pi/extensions/runtime/index.ts	Runtime policy via projections
src/.pi/extensions/README.md	Add extensions topology README
src/.pi/extensions/mentions/index.ts	New mention autocomplete provider
src/.pi/extensions/graph/index.ts	Use projections/renderers
src/.pi/extensions/exchanges/shared/recovery.ts	New Zod-based recovery
src/.pi/extensions/exchanges/shared/markdown.ts	Shared markdown helpers
src/.pi/extensions/exchanges/schemas/README.md	Expand schema boundary docs
src/.pi/extensions/exchanges/schemas/index.ts	Export params schema module
src/.pi/extensions/exchanges/schemas/capture.ts	Centralize tool_meta atoms
src/.pi/extensions/exchanges/request-review.ts	Implement request_review tool
src/.pi/extensions/exchanges/request-choice.ts	Implement request_choice tool
src/.pi/extensions/exchanges/request-answer.ts	Implement request_answer tool
src/.pi/extensions/exchanges/present-review-set.ts	Implement present_review_set tool
src/.pi/extensions/exchanges/present-question.ts	Switch to Zod param schema
src/.pi/extensions/exchanges/present-options.ts	Implement present_options tool
src/.pi/extensions/exchanges/present-candidates.ts	Keep present_candidates stub
src/.pi/extensions/exchanges/pi-schema.ts	Zod→Pi schema adapter
src/.pi/extensions/exchanges/index.ts	Register exchange tools w/ deps
src/.pi/extensions/context/get-cwd.ts	Add concept note stub
src/.pi/extensions/compaction/index.ts	Add compaction anchor contract
src/.pi/extensions/commands/policy.ts	Block Pi branch/tree flows
src/.pi/extensions/commands/index.ts	Repoint workspace command import
src/.pi/extensions/auto-compaction-anchors.json	Remove JSON anchor contract
src/.pi/extensions/AUDIT.md	Add extension audit index
src/.pi/components/workspace-dialog/component.ts	Fix package.json URL path
src/.pi/components/alternatives.ts	Fix relative import
src/.pi/brunch-pi-settings.ts	Rename profile→settings types
src/.pi/agents/state.ts	Drive policy via runtime-policy
src/.pi/agents/state.test.ts	Assert tool policy gating
src/.pi/agents/README.md	Add agents topology README
src/.pi/agents/index.ts	Add agents barrel exports
src/.pi/agents/definitions/reviewer.md	Add reviewer definition stub
src/.pi/agents/definitions/elicitor.md	Add elicitor definition
src/.pi/agents/contexts/node.ts	Use projections/renderers
src/.pi/agents/contexts/node.test.ts	Fix import paths
src/.pi/agents/contexts/index.ts	Add contexts barrel export
src/.pi/agents/contexts/graph.ts	Clarify selected-spec LSN text
src/.pi/agents/contexts/graph.test.ts	Assert selected-spec LSN text
src/.pi/agents/contexts/cwd.ts	Add workspace context renderer
src/.pi/agents/contexts/cwd.test.ts	Add cwd context tests
src/.pi/agents/compose.ts	Use projected runtime state type
src/.pi/agents/compose.test.ts	Update resource location checks
src/.pi/agents/architecture.test.ts	Update resource paths
src/.pi/tests/workspace-dialog.test.ts	Update version assertions
src/.pi/tests/structured-exchange.test.ts	Update exchange module import
src/.pi/tests/structured-exchange-extension.test.ts	Update exchange module import
src/.pi/tests/structured-exchange-boundaries.test.ts	Add boundary enforcement tests
src/.pi/tests/prompting.test.ts	Update to new shell/registrars
src/.pi/tests/operational-mode.test.ts	Update tool policy output
src/.pi/tests/mention-autocomplete.test.ts	Update mention extension import
src/.pi/tests/graph-tools.test.ts	Seed spec via CommandExecutor
src/.pi/tests/extension-registry.test.ts	Update explicit extension registry
package.json	Move entrypoint; add Tailwind deps
memory/cards/poc-live-ship-gate--live-mention-autocomplete.md	Add live-mention slice card
drizzle/meta/_journal.json	Add migration journal entry
drizzle/0002_spec_scoped_graph_clock.sql	Migrate clock/log to spec scope
docs/design/GRAPH_MODEL.md	Update prompt resource links
docs/archive/PLAN_HISTORY.md	Archive topology sync summary
docs/architecture/pi-ui-extension-patterns.md	Update path references
bin/brunch-cli.js	Update dist entry import
.fixtures/README.md	Add review-cycle tracer entry

Comments suppressed due to low confidence (1)

src/.pi/extensions/exchanges/index.ts:35

StructuredExchangeToolResultDetails is currently re-exported as RequestChoiceDetails, which is too narrow (e.g. the RPC editor fallback can return request_choices details). This makes the exported type misleading for consumers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  const base = {
+    schema: STRUCTURED_EXCHANGE_REQUEST_DETAILS_SCHEMA,
+    v: 1,
+    exchange_id: input.exchangeId,
+    tool_meta: {
+      prev: input.respondsToPresentTool,
+      curr: 'request_choice' as const,
+    },
+  };


Signed-off-by: Lu Nelson <ln@hash.ai>

graphite-app · 2026-06-08T10:23:54Z

Merge activity

Jun 8, 10:23 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

lunelson mentioned this pull request Jun 5, 2026

FE-807: Structured response capture into selected-spec graph truth #173

Merged

lunelson force-pushed the ln/fe-807-capture-response-to-graph branch from 597841f to 221be7e Compare June 5, 2026 12:40

lunelson force-pushed the ln/fe-809-project-graph-review-cycle branch from b1f964a to 2147778 Compare June 5, 2026 12:40

lunelson marked this pull request as ready for review June 6, 2026 16:45

Copilot AI review requested due to automatic review settings June 6, 2026 16:45

Copilot started reviewing on behalf of lunelson June 6, 2026 16:45 View session

lunelson mentioned this pull request Jun 6, 2026

FE-811: Elicitor cross-cut groundwork and read/project/render cleanup #177

Merged

lunelson changed the title ~~Add Pi worktree switch selector~~ FE-809: Project-graph review-set proposal and atomic acceptance Jun 6, 2026

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/projections/structured-exchange/request-choice.ts

Comment on lines +18 to +26

const base = {

schema: STRUCTURED_EXCHANGE_REQUEST_DETAILS_SCHEMA,

v: 1,

exchange_id: input.exchangeId,

tool_meta: {

prev: input.respondsToPresentTool,

curr: 'request_choice' as const,

},

};

This was referenced Jun 8, 2026

FE-823: Elicitation backlog substrate and agenda read-back #178

Open

FE-811: Ship-gate rename residue and live mention autocomplete #179

Draft

Base automatically changed from ln/fe-807-capture-response-to-graph to next June 8, 2026 10:22

lunelson added 6 commits June 8, 2026 10:23

Add Pi worktree switch selector

be10648

first cards for fe-809

63059c0

adjusted seed workflow doc

77f7c06

fix for workspace.json state ownership

0aee20c

Spec-scope graph LSNs

b39731c

Enforce graph clock rows

707efe3

lunelson added 26 commits June 8, 2026 10:23

Refine Brunch TUI chrome

1386779

FE-809: Add graph review-set acceptance

dd4135a

Add Tailwind web styling proof

2fd9846

Add DB fixture export tooling

88539bc

FE-809: Wire review-set structured exchange

6f6af08

FE-809: Retire review-cycle core card

f96abe5

plan and scope collection

47e8625

FE-809: Lock structured exchange details schemas

60c17f5

refactor for schema lock

31defd8

FE-809: Move structured exchange tools to Zod projectors

c5f3154

FE-809: Single-source structured exchange schema atoms

df56dab

FE-809: Retire legacy structured exchange result path

aebfc7d

FE-809: Harden structured exchange schema boundaries

8b5c0fd

FE-809: Reconcile structured exchange schema lock

ade0232

FE-809: Close structured exchange emission boundary

bbae0bb

3 final slice scopes for fe-809

39ae3f1

Rehome Pi runtime topology

0da1d5d

renames of main brunch pi init files

5a2028f

Signed-off-by: Lu Nelson <ln@hash.ai>

Move root sources into topology layers

441d877

Hoist projection and renderer topology

c4c8cf4

Apply projected runtime tool policy

897267b

Prevent TUI tests from opening browsers

a5133ea

update mention autocomplete scope, post topology change

a04926e

Sync topology planning state

044da3b

FE-809 wire review approval RPC

ea8bb82

FE-809 prove project-graph review cycle

d0b6617

lunelson force-pushed the ln/fe-809-project-graph-review-cycle branch from e422e5d to d0b6617 Compare June 8, 2026 10:23

lunelson merged commit 46469ce into next Jun 8, 2026
6 checks passed

lunelson deleted the ln/fe-809-project-graph-review-cycle branch June 8, 2026 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FE-809: Project-graph review-set proposal and atomic acceptance#175

FE-809: Project-graph review-set proposal and atomic acceptance#175
lunelson merged 33 commits into
nextfrom
ln/fe-809-project-graph-review-cycle

lunelson commented Jun 5, 2026 •

edited

Loading

Uh oh!

lunelson commented Jun 5, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jun 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app Bot commented Jun 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lunelson commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack Context

What?

Why?

Verification

Uh oh!

lunelson commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

graphite-app Bot commented Jun 8, 2026

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lunelson commented Jun 5, 2026 •

edited

Loading

lunelson commented Jun 5, 2026 •

edited

Loading

cursor Bot commented Jun 6, 2026 •

edited

Loading