Skip to content

refactor(tiny-transition): implement transition as "lagged boolean state"#93

Merged
hi-ogawa merged 33 commits intomainfrom
refactor-tiny-transition-lagged-state
Oct 25, 2023
Merged

refactor(tiny-transition): implement transition as "lagged boolean state"#93
hi-ogawa merged 33 commits intomainfrom
refactor-tiny-transition-lagged-state

Conversation

@hi-ogawa
Copy link
Copy Markdown
Owner

@hi-ogawa hi-ogawa commented Oct 23, 2023

Inspired by

this approach seems like a generalized/simplified implementation of "transition manager" core.

todo

  • show=true appear=false broken in solidjs? e9c8afd
    • it seems it's tricky to play on class/style/ref to do something effectful...

@hi-ogawa hi-ogawa marked this pull request as ready for review October 23, 2023 12:41
@hi-ogawa
Copy link
Copy Markdown
Owner Author

It looks like this approach is completely compatible with old implementation, so let's go on to remove old stuff.

@hi-ogawa hi-ogawa changed the title refactor(tiny-transition): "lagged state" interpretion of transition refactor(tiny-transition): implement transition as "lagged boolean state" Oct 25, 2023
@hi-ogawa hi-ogawa merged commit 1170950 into main Oct 25, 2023
@hi-ogawa hi-ogawa deleted the refactor-tiny-transition-lagged-state branch October 25, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant