Improve study test iframe preview health checks, app status messaging, and overlays#807
Open
mohiuddinshahrukh wants to merge 4 commits into
Open
Conversation
johannesvedder
requested changes
Apr 20, 2026
Contributor
johannesvedder
left a comment
johannesvedder
left a comment
There was a problem hiding this comment.
Thanks for the PR and the additions. It looks much better now! Some things I noticed:
-
Can we remove the transparency?
-
Let's skip the /onboarding for the preview as it's purpose is to introduce new participants to the app:
- When switching pakes using the links on the left side, I am stuck in the checking connection loading screen. I need to click "Reset" to show the correct page.
Disable test page navigation until the iframe preview is ready, route page changes through postMessage after load, and keep preview back behavior on logical onboarding steps. Clear stale preview subject references so reset previews can recreate a missing subject.
Collaborator
Author
|
One two and three have been fixed, although number 3 is a bit more complicated to solve since the back button action is a bit of a tricky thing to handle, it sometimes makes the phone app crash and sometimes behaves unexpectedly, this can be easily reproduced by clicking schedule and then back on the deployed version also. Shall you find some other room for improvements, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the study test preview flow between
designer_v2and the embedded app iframe.It adds:
Behavior
The test preview now follows this flow:
If the app is unreachable:
Scope
This PR intentionally includes only the files related to: