fix(measurements): persist new survey questions#819
Open
mohiuddinshahrukh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes the measurements survey editor so newly created questions are saved correctly and duplicated questions no longer fail.
Why
Creating a question in a brand-new measurement could appear to succeed, but the question would not remain visible because the route stayed on
/measurements/newand reopened a fresh staged survey after save. Duplicating a fresh question could also fail becauseresponseOptionsValiditywas read before it had been initialized.User impact
Users can now:
Root cause
There were two issues in the measurements flow:
responseOptionsValidityhad always been initializednewroute to the real measurement id after the first saveValidation