fix(measurements): persist new survey questions

designer_v2/lib/features/design/measurements/measurements_form_controller.dart

@@ -194,12 +194,23 @@ class MeasurementsFormViewModel extends FormViewModel<MeasurementsFormData>
     MeasurementSurveyFormViewModel formViewModel,
     FormMode prevFormMode,
   ) async {
+    final isNewMeasurement = prevFormMode == FormMode.create;
+
     if (prevFormMode == FormMode.create) {
       // Commit the managed viewmodel that was eagerly added in [provide]
       surveyMeasurementFormViewModels.commit(formViewModel);
     } else if (prevFormMode == FormMode.edit) {
       // nothing to do here
     }
     await super.save();
+
+    if (isNewMeasurement) {
+      router.dispatch(
+        RoutingIntents.studyEditMeasurement(
+          study.id,
+          formViewModel.measurementId,
+        ),
+      );
+    }
   }
 }

designer_v2/lib/features/design/measurements/survey/survey_form_controller.dart

@@ -30,7 +30,10 @@ class MeasurementSurveyFormViewModel
     super.delegate,
     super.formData,
     super.validationSet = StudyFormValidationSet.draft,
-  });
+  }) {
+    // Persist survey changes when managed questions are added, edited, or removed.
+    propagateOnSave = true;
+  }
 
   final Study study;
 

designer_v2/lib/features/design/shared/questionnaire/question/question_form_data.dart

@@ -94,7 +94,7 @@ abstract class QuestionFormData implements IFormData {
   final QuestionConditional? conditional;
 
   /// Mapping from response option => qualifying/disqualifying
-  late final Map<dynamic, bool> responseOptionsValidity;
+  Map<dynamic, bool> responseOptionsValidity = {};
 
   List<dynamic> get responseOptions; // subclass responsibility
 
@@ -239,7 +239,7 @@ class ChoiceQuestionFormData extends QuestionFormData {
       answerOptions: [...answerOptions],
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -307,7 +307,7 @@ class BoolQuestionFormData extends QuestionFormData {
       questionInfoText: questionInfoText,
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -374,7 +374,7 @@ class ImageQuestionFormData extends QuestionFormData {
       questionInfoText: questionInfoText,
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -448,7 +448,7 @@ class AudioQuestionFormData extends QuestionFormData {
       conditional: conditional?.deepCopy(),
       maxRecordingDurationSeconds: maxRecordingDurationSeconds,
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -585,7 +585,7 @@ class ScaleQuestionFormData extends QuestionFormData {
       midValues: midValues,
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -664,7 +664,7 @@ class FreeTextQuestionFormData extends QuestionFormData {
       textTypeExpression: textTypeExpression,
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -733,7 +733,7 @@ class FitbitQuestionFormData extends QuestionFormData {
       types: types,
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }
 
@@ -814,7 +814,7 @@ class PainQuestionFormData extends QuestionFormData {
       questionInfoText: questionInfoText,
       conditional: conditional?.deepCopy(),
     );
-    data.responseOptionsValidity = responseOptionsValidity;
+    data.responseOptionsValidity = {...responseOptionsValidity};
     return data;
   }