Skip to content

fix: Pin Input keyboard nav/replacement#1872

Merged
huntabyte merged 6 commits into
mainfrom
fix/1869
Jan 28, 2026
Merged

fix: Pin Input keyboard nav/replacement#1872
huntabyte merged 6 commits into
mainfrom
fix/1869

Conversation

@huntabyte

@huntabyte huntabyte commented Oct 30, 2025

Copy link
Copy Markdown
Owner

WIP
Closes #1869

@changeset-bot

changeset-bot Bot commented Oct 30, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bd2dd79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 30, 2025

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview bd2dd79

@artur-demidov

Copy link
Copy Markdown

Hi. I see you've added tests for this component, cool. I found the problem. There's an error in the algorithm compared to input-otp. If both libraries work the same, then in file pin-input.svelte.ts line 353 should be
direction = c < prev[1] ? "backward" : "forward"; link
and line 360 should be
start = offset + c; link

@huntabyte huntabyte marked this pull request as ready for review November 10, 2025 03:25
@huntabyte

Copy link
Copy Markdown
Owner Author

Thank you! @artur-demidov

@huntabyte huntabyte merged commit db9d917 into main Jan 28, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request Jan 28, 2026
@huntabyte huntabyte deleted the fix/1869 branch March 14, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard navigation in PIN-input(OTP) is broke

2 participants