Skip to content

fix: Pin Input keyboard nav/replacement #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntabyte merged 6 commits into from
Jan 28, 2026
Merged

fix: Pin Input keyboard nav/replacement #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1afec0
confirm via tests
huntabyte Oct 30, 2025
e8204d4
fix(PinInput): keyboard navigation
huntabyte Nov 10, 2025
7e4c316
Merge branch 'main' into fix/1869
huntabyte Jan 28, 2026
7d1eeba
formatting
huntabyte Jan 28, 2026
8e296c6
fix: lint
huntabyte Jan 28, 2026
bd2dd79
Merge branch 'main' into fix/1869
huntabyte Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fruity-singers-rule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"bits-ui": patch
---

fix(Pin Input): keyboard navigation
4 changes: 2 additions & 2 deletions packages/bits-ui/src/lib/bits/pin-input/pin-input.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,14 +350,14 @@ export class PinInputRootState {
} else if (maxLength > 1 && val.length > 1) {
let offset = 0;
if (prev[0] !== null && prev[1] !== null) {
direction = c < prev[0] ? "backward" : "forward";
direction = c < prev[1] ? "backward" : "forward";
const wasPreviouslyInserting = prev[0] === prev[1] && prev[0] < maxLength;
if (direction === "backward" && !wasPreviouslyInserting) {
offset = -1;
}
}

start = offset - c;
start = offset + c;
end = offset + c + 1;
}
}
Expand Down
115 changes: 114 additions & 1 deletion tests/src/tests/pin-input/pin-input.browser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { render } from "vitest-browser-svelte";
import { REGEXP_ONLY_DIGITS } from "bits-ui";
import { getTestKbd } from "../utils.js";
import PinInputTest from "./pin-input-test.svelte";
import { type ComponentProps } from "svelte";
import type { ComponentProps } from "svelte";
import { page, userEvent } from "@vitest/browser/context";

const kbd = getTestKbd();
Expand Down Expand Up @@ -220,3 +220,116 @@ it("should allow pasting more than the max-length if transformation is provided"
expect(mockComplete).toHaveBeenCalledTimes(1);
expect(mockComplete).toHaveBeenCalledWith("123456");
});

it("should handle ArrowLeft navigation correctly", async () => {
const t = setup();

await t.hiddenInput.click();
await userEvent.keyboard("1");
await userEvent.keyboard("2");
await userEvent.keyboard("3");
await userEvent.keyboard("4");
await expect.element(t.hiddenInput).toHaveValue("1234");
await expect.element(t.cells[4]).toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[3]).toHaveAttribute("data-active");
await expect.element(t.cells[4]).not.toHaveAttribute("data-active");
await expect.element(t.cells[2]).not.toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[2]).toHaveAttribute("data-active");
await expect.element(t.cells[3]).not.toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[1]).toHaveAttribute("data-active");
await expect.element(t.cells[2]).not.toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[0]).toHaveAttribute("data-active");
await expect.element(t.cells[1]).not.toHaveAttribute("data-active");
});

it("should correctly replace characters when navigating back and typing", async () => {
const t = setup();

await t.hiddenInput.click();
await t.hiddenInput.fill("1234");
await expect.element(t.hiddenInput).toHaveValue("1234");

// navigate to beginning using Home
await userEvent.keyboard(kbd.HOME);
await expect.element(t.cells[0]).toHaveAttribute("data-active");

// type 5 and 6 - should replace first two characters
await userEvent.keyboard("5");
await expect.element(t.hiddenInput).toHaveValue("5234");
await expect.element(t.cells[0]).toHaveTextContent("5");
await expect.element(t.cells[1]).toHaveAttribute("data-active");

await userEvent.keyboard("6");
await expect.element(t.hiddenInput).toHaveValue("5634");
await expect.element(t.cells[0]).toHaveTextContent("5");
await expect.element(t.cells[1]).toHaveTextContent("6");
await expect.element(t.cells[2]).toHaveTextContent("3");
await expect.element(t.cells[3]).toHaveTextContent("4");
});

it("should correctly replace characters when navigating back with ArrowLeft and typing", async () => {
const t = setup();

await t.hiddenInput.click();
await t.hiddenInput.fill("1234");
await expect.element(t.hiddenInput).toHaveValue("1234");

// navigate back using ArrowLeft
await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[3]).toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[2]).toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[1]).toHaveAttribute("data-active");

await userEvent.keyboard(kbd.ARROW_LEFT);
await expect.element(t.cells[0]).toHaveAttribute("data-active");

// type 5 and 6 - should replace first two characters
await userEvent.keyboard("5");
await expect.element(t.hiddenInput).toHaveValue("5234");
await expect.element(t.cells[0]).toHaveTextContent("5");
await expect.element(t.cells[1]).toHaveAttribute("data-active");

await userEvent.keyboard("6");
await expect.element(t.hiddenInput).toHaveValue("5634");
await expect.element(t.cells[0]).toHaveTextContent("5");
await expect.element(t.cells[1]).toHaveTextContent("6");
await expect.element(t.cells[2]).toHaveTextContent("3");
await expect.element(t.cells[3]).toHaveTextContent("4");
});

it("should correctly replace characters when navigating with ArrowUp and typing", async () => {
const t = setup();

await t.hiddenInput.click();
await t.hiddenInput.fill("1234");
await expect.element(t.hiddenInput).toHaveValue("1234");

// navigate to beginning using ArrowUp (equivalent to Home)
await userEvent.keyboard(kbd.ARROW_UP);
await expect.element(t.cells[0]).toHaveAttribute("data-active");

// type 5 and 6 - should replace first two characters
await userEvent.keyboard("5");
await expect.element(t.hiddenInput).toHaveValue("5234");
await expect.element(t.cells[0]).toHaveTextContent("5");
await expect.element(t.cells[1]).toHaveAttribute("data-active");

await userEvent.keyboard("6");
await expect.element(t.hiddenInput).toHaveValue("5634");
await expect.element(t.cells[0]).toHaveTextContent("5");
await expect.element(t.cells[1]).toHaveTextContent("6");
await expect.element(t.cells[2]).toHaveTextContent("3");
await expect.element(t.cells[3]).toHaveTextContent("4");
});