IBX-10879: Added possibility to disable/enable drop-down options#1894
Open
IBX-10879: Added possibility to disable/enable drop-down options#1894
Conversation
vidarl
force-pushed
the
IBX-10879_Add_possibility_to_disable_enable_drop_down_options
branch
from
4743a6d to
cbb704a
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick,
dew326 and
tischsoic
and removed request for
a team
albozek
approved these changes
Apr 30, 2026
| } | ||
|
|
||
| onSelect(element, selected) { | ||
| if (!element || element.classList.contains('ibexa-dropdown__item--disabled')) { |
Contributor
There was a problem hiding this comment.
nitpick: maybe it would be a good idea to put this in a separate helper function as it is repeated three times:
checkIsOptionDisabled = (option) => { return option.classList.contains('ibexa-dropdown__item--disabled') };
your call :)
| const option = this.sourceInput.querySelector(`[value=${stringifiedValue}]`); | ||
|
|
||
| if (item) { | ||
| item.classList.add('ibexa-dropdown__item--disabled'); |
Contributor
There was a problem hiding this comment.
same as above. That ‘ifs’ are repeated so maybe toggleOptionEnabled?
dew326
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR makes it possible to enable/disable options in a drop-down
For QA:
See QA description in ibexa/automated-translation#33
Documentation: