Skip to content

IBX-10879: Added possibility to disable/enable drop-down options #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vidarl wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

IBX-10879: Added possibility to disable/enable drop-down options #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 58 additions & 3 deletions src/bundle/Resources/public/js/scripts/core/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@
const stringifiedValue = JSON.stringify(String(value));
const optionToSelect = this.itemsListContainer.querySelector(`.ibexa-dropdown__item[data-value=${stringifiedValue}]`);

if (optionToSelect?.classList.contains('ibexa-dropdown__item--disabled')) {
return;
}

return this.onSelect(optionToSelect, true);
}

Expand Down Expand Up @@ -243,6 +247,10 @@
}

onSelect(element, selected) {
if (!element || element.classList.contains('ibexa-dropdown__item--disabled')) {
Copy link
Copy Markdown
Contributor

@albozek albozek Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: maybe it would be a good idea to put this in a separate helper function as it is repeated three times:
checkIsOptionDisabled = (option) => { return option.classList.contains('ibexa-dropdown__item--disabled') };
your call :)

return;
}

if (this.canSelectOnlyOne && selected) {
this.hideOptions();
this.clearCurrentSelection(false);
Expand Down Expand Up @@ -294,6 +302,11 @@

onOptionClick({ target }) {
const option = target.closest('.ibexa-dropdown__item');

if (!option || option.classList.contains('ibexa-dropdown__item--disabled')) {
return;
}

const isSelected = this.canSelectOnlyOne || !option.classList.contains('ibexa-dropdown__item--selected');

return this.onSelect(option, isSelected);
Expand Down Expand Up @@ -455,7 +468,7 @@
});

optionsToRecreate.forEach((option) => {
this.createOption(option.value, option.innerHTML);
this.createOption(option.value, option.innerHTML, option.disabled);
});

const selectedItems = this.getSelectedItems();
Expand All @@ -479,14 +492,19 @@
optionNode.remove();
}

createOption(value, label) {
createOption(value, label, isDisabled = false) {
const container = doc.createElement('div');
const itemRendered = this.itemTemplate.replaceAll('{{ value }}', escapeHTMLAttribute(value)).replaceAll('{{ label }}', label);

container.insertAdjacentHTML('beforeend', itemRendered);

const optionNode = container.firstElementChild;

if (isDisabled) {
optionNode.classList.add('ibexa-dropdown__item--disabled');
optionNode.setAttribute('aria-disabled', 'true');
}

optionNode.addEventListener('click', this.onOptionClick, false);
this.itemsListContainer.append(optionNode);
}
Expand Down Expand Up @@ -578,7 +596,7 @@
this.itemsPopover._element.addEventListener('shown.bs.popover', this.onPopoverShow);
this.itemsPopover._element.addEventListener('hidden.bs.popover', this.onPopoverHide);
this.itemsListContainer
.querySelectorAll('.ibexa-dropdown__item:not([disabled])')
.querySelectorAll('.ibexa-dropdown__item:not(.ibexa-dropdown__item--disabled)')
.forEach((option) => option.addEventListener('click', this.onOptionClick, false));

if (this.itemsFilterInput) {
Expand Down Expand Up @@ -626,6 +644,43 @@

selectedItems.forEach((selectedItem) => this.attachSelectedItemEvents(selectedItem));
}

disableOption(value) {
const stringifiedValue = JSON.stringify(String(value));
const item = this.itemsListContainer.querySelector(`[data-value=${stringifiedValue}]`);
const option = this.sourceInput.querySelector(`[value=${stringifiedValue}]`);

if (item) {
item.classList.add('ibexa-dropdown__item--disabled');
Copy link
Copy Markdown
Contributor

@albozek albozek Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above. That ‘ifs’ are repeated so maybe toggleOptionEnabled?

item.setAttribute('aria-disabled', 'true');
}

if (option) {
option.disabled = true;
}
}

enableOption(value) {
const stringifiedValue = JSON.stringify(String(value));
const item = this.itemsListContainer.querySelector(`[data-value=${stringifiedValue}]`);
const option = this.sourceInput.querySelector(`[value=${stringifiedValue}]`);

if (item) {
item.classList.remove('ibexa-dropdown__item--disabled');
item.removeAttribute('aria-disabled');
}

if (option) {
option.disabled = false;
}
}

isOptionDisabled(value) {
const stringifiedValue = JSON.stringify(String(value));
const option = this.sourceInput.querySelector(`[value=${stringifiedValue}]`);

return option.disabled;
}
}

ibexa.addConfig('core.Dropdown', Dropdown);
Expand Down
9 changes: 9 additions & 0 deletions src/bundle/Resources/public/scss/_dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,3 +557,12 @@
margin: calculateRem(5px) calculateRem(8px);
}
}

.ibexa-dropdown__item--disabled {
opacity: 0.5;
cursor: not-allowed;
}

.ibexa-dropdown__item--disabled * {
pointer-events: none;
}
Loading