Conversation
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
8581211 to
3a92ffb
Compare
|
There was a problem hiding this comment.
Pull request overview
Updates Symfony Flex recipe manifests to change how frontend Encore assets are compiled during Composer auto-scripts, aiming to optimize the compilation approach across Ibexa 5.0 editions.
Changes:
- Replaces a single multi-config
ibexa:encore:compile --frontend-configs-name ibexa,internals,libs,richtextscript entry with four per-config compile entries. - Applies the same composer-scripts change consistently across OSS, Headless, Experience, and Commerce 5.0 recipe manifests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ibexa/oss/5.0/manifest.json | Splits frontend Encore compilation into four per-config script entries. |
| ibexa/headless/5.0/manifest.json | Splits frontend Encore compilation into four per-config script entries. |
| ibexa/experience/5.0/manifest.json | Splits frontend Encore compilation into four per-config script entries. |
| ibexa/commerce/5.0/manifest.json | Splits frontend Encore compilation into four per-config script entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", |
There was a problem hiding this comment.
Running ibexa:encore:compile four times (once per frontend config) will boot Symfony and execute the compilation pipeline four times during install/build, which typically adds noticeable overhead versus a single compilation run. Unless the command cannot accept multiple config names per invocation, it’s usually more efficient to keep a single command and pass all requested configs at once.
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd", |
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", |
There was a problem hiding this comment.
This replaces one multi-config ibexa:encore:compile command with four separate commands. Since Composer runs these auto-scripts sequentially, this will usually increase total build time due to repeated Symfony console bootstrap and repeated compilation setup work. If the intent is improved caching or incremental builds, consider consolidating into a single invocation (if supported) or explain why multiple invocations are required.
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd", |
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", |
There was a problem hiding this comment.
This change replaces a single ibexa:encore:compile invocation with four separate console invocations. Because each entry boots Symfony and runs the command separately, this typically increases install/build time and resource usage (and can reduce the intended “optimization” benefit). If the goal is to compile these configs separately, consider doing it within a single command invocation (e.g., passing multiple config names in one run if supported) or document why multiple invocations are required here.
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd", |
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | ||
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", |
There was a problem hiding this comment.
Splitting the frontend assets compilation into four separate ibexa:encore:compile script entries means Symfony is booted four times during composer auto-scripts. That usually increases overall installation/build time and CPU/memory usage compared to compiling all requested configs in a single command run. If there’s a functional reason to split these (e.g., caching/partial rebuild behavior), it would help to keep a single invocation if possible or add a brief justification in the recipe history/PR description.
| "ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd", | |
| "ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd", |



Description:
For QA:
Documentation: