Skip to content

IBX-11652: Optimize compilation approach for frontend assets #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dew326 merged 1 commit into from
Apr 22, 2026
Merged

IBX-11652: Optimize compilation approach for frontend assets #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ibexa/commerce/5.0/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,10 @@
"yarn ibexa-generate-tsconfig --use-relative-paths": "script",
"ibexa:encore:compile --config-name app": "symfony-cmd",
"bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa,internals,libs,richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
Comment on lines +172 to +175
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces one multi-config ibexa:encore:compile command with four separate commands. Since Composer runs these auto-scripts sequentially, this will usually increase total build time due to repeated Symfony console bootstrap and repeated compilation setup work. If the intent is improved caching or incremental builds, consider consolidating into a single invocation (if supported) or explain why multiple invocations are required.

Suggested change
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd",

Copilot uses AI. Check for mistakes.
"ibexa:encore:compile": "symfony-cmd"
}
}
5 changes: 4 additions & 1 deletion ibexa/experience/5.0/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,10 @@
"yarn ibexa-generate-tsconfig --use-relative-paths": "script",
"ibexa:encore:compile --config-name app": "symfony-cmd",
"bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa,internals,libs,richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
Comment on lines +165 to +168
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running ibexa:encore:compile four times (once per frontend config) will boot Symfony and execute the compilation pipeline four times during install/build, which typically adds noticeable overhead versus a single compilation run. Unless the command cannot accept multiple config names per invocation, it’s usually more efficient to keep a single command and pass all requested configs at once.

Suggested change
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd",

Copilot uses AI. Check for mistakes.
"ibexa:encore:compile": "symfony-cmd"
}
}
5 changes: 4 additions & 1 deletion ibexa/headless/5.0/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,10 @@
"yarn ibexa-generate-tsconfig --use-relative-paths": "script",
"ibexa:encore:compile --config-name app": "symfony-cmd",
"bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa,internals,libs,richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
Comment on lines +146 to +149
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting the frontend assets compilation into four separate ibexa:encore:compile script entries means Symfony is booted four times during composer auto-scripts. That usually increases overall installation/build time and CPU/memory usage compared to compiling all requested configs in a single command run. If there’s a functional reason to split these (e.g., caching/partial rebuild behavior), it would help to keep a single invocation if possible or add a brief justification in the recipe history/PR description.

Suggested change
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd",

Copilot uses AI. Check for mistakes.
"ibexa:encore:compile": "symfony-cmd"
}
}
5 changes: 4 additions & 1 deletion ibexa/oss/5.0/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@
"yarn ibexa-generate-tsconfig --use-relative-paths": "script",
"ibexa:encore:compile --config-name app": "symfony-cmd",
"bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa,internals,libs,richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
Comment on lines +97 to +100
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces a single ibexa:encore:compile invocation with four separate console invocations. Because each entry boots Symfony and runs the command separately, this typically increases install/build time and resource usage (and can reduce the intended “optimization” benefit). If the goal is to compile these configs separately, consider doing it within a single command invocation (e.g., passing multiple config names in one run if supported) or document why multiple invocations are required here.

Suggested change
"ibexa:encore:compile --frontend-configs-name ibexa": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name internals": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name libs": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name richtext": "symfony-cmd",
"ibexa:encore:compile --frontend-configs-name ibexa --frontend-configs-name internals --frontend-configs-name libs --frontend-configs-name richtext": "symfony-cmd",

Copilot uses AI. Check for mistakes.
"ibexa:encore:compile": "symfony-cmd"
}
}
Loading