Artificial viscosity by w-hagen · Pull Request #213 · illinois-ceesd/mirgecom

w-hagen · 2021-02-03T18:38:56Z

This branch implements a modal indicator based artificial viscosity approach to enable shock capturing.

Outstanding work needed before moving forward:

Clean up boundary condition routines utilized for the artificial viscosity
Expose smoothness indicator parameters
Remove unnecessary make_obj_array calls
Bring branch up to master
Add documentation of approach
Add tests for additions

…tions

… emirge

Silence pydocstyle.

Silence flake8

Av mrg master

Remove un-needed make_obj_array calls

MTCam · 2021-05-06T02:57:40Z

CI failures due to inducer/grudge#83 moving stuff around. @thomasgibson. Fixed these in NS with:
(e451ea4, e4cb256).

@MTCam I'll take care of these updates and I'll file a mirgecom PR and one against @w-hagen's branch

Thanks a ton, @thomasgibson!

* clean up object array handling in flux routines * add note about get_array_container_context

MTCam · 2021-05-07T19:59:20Z

Hey... the (approve and run) button went away. 🎉

* remove call to deprecated create_parallel_grid * remove use of deprecated n parameter * add boundary_kwargs to av_operator * raise exception instead of asserting

Co-authored-by: Matthias Diener <matthias.diener@gmail.com>

MTCam · 2022-06-25T12:54:41Z

Closing this as stale. We merged AV in #582

w-hagen and others added 17 commits October 28, 2020 18:22

Initial implementation of artificial viscosity for the euler equations

8e7ddda

Initial implementation of smoothness indicator

59f80c3

Updated modal smoothness indicator to mode_ids to select highest mode

122966e

Fixed updated artificial viscosity implementation to use desired equa…

598e4b6

…tions

Add boundary condition function to return projected boundary solution

822d863

Added double mach reflection example problem

e0f0ce4

Added double mach reflection example problem

d35771a

Remove reference to unnecessary heat operator

a71ac3b

Fixed error in calculating face fluxes across ranks

0f132eb

Removed unessecary reference to heat operator

40656f3

Fixed error in not distributing grid

d49de59

Added shock indicator and integrated with artificial viscosity

80e1a62

Added output field for shock indicator

0c25238

Modified stepping parameters for scaling tests

96fc18c

Fixed artifical viscosity boundary conditions

446cace

Merge branch 'master' into av-mrg-master

7a9a81d

Bring back functions inadvertently removed in hand merge

bf67fc0

w-hagen mentioned this pull request Feb 3, 2021

Merge in changes from upstream master (for better or worse). w-hagen/mirgecom#1

Merged

w-hagen and others added 12 commits February 3, 2021 16:52

Minimum changes to bring boundary conditions up to date with mainline…

f52b8b6

… emirge

Merges the upstream master

37abb66

Silence flake8.

703869a

Silence pydocstyle

f20059f

Merge pull request #3 from w-hagen/silence-pydocstyle

125ff51

Silence pydocstyle.

Merge pull request #2 from w-hagen/silence-flake8

5c99ac1

Silence flake8

merge updated master into artificial viscosity branch

d978414

Merge pull request #4 from w-hagen/av-mrg-master

8d30def

Av mrg master

Remove un-needed make_obj_array calls

1340ea6

Merge pull request #5 from w-hagen/remove-mkobjarray

067ad2b

Remove un-needed make_obj_array calls

Rework boundary conditions to avoid duplicating code

9d32a7a

Fix docstyle, remove unused import

3a13a05

thomasgibson mentioned this pull request May 5, 2021

Update double mach experiment against recent Grudge updates w-hagen/mirgecom#22

Merged

MTCam and others added 5 commits May 6, 2021 08:23

Merge branch 'main' into artificial_viscosity

56e5efd

Rewrite shock indicator, cache program and mode computations (#20)

70a4696

Update double mach example (#22)

7090d32

Clean up object array handling in flux routines (#19)

445c5c8

* clean up object array handling in flux routines * add note about get_array_container_context

Merge branch 'main' into artificial_viscosity

d185c95

MTCam added 2 commits May 7, 2021 15:03

Sooth the bugbear.

e2d7ddd

Unpoke the bugbear.

3a61993

MTCam mentioned this pull request May 10, 2021

Add av to ns #338

Closed

majosm and others added 3 commits May 10, 2021 19:33

AV misc fixes (#23)

59df6df

* remove call to deprecated create_parallel_grid * remove use of deprecated n parameter * add boundary_kwargs to av_operator * raise exception instead of asserting

Rename modes_active_flag

c0578f2

Merge branch 'main' into artificial_viscosity

bfe3658

MTCam added a commit that referenced this pull request May 13, 2021

Pick up current AV from @w-hagen #213

99de611

MTCam added 3 commits May 14, 2021 15:01

Merge branch 'main' into artificial_viscosity

fb44717

Merge branch 'main' into artificial_viscosity

557df33

Merge branch 'main' into artificial_viscosity

f9e7884

matthiasdiener reviewed Jun 25, 2021

View reviewed changes

Comment thread mirgecom/artificial_viscosity.py Outdated

w-hagen and others added 7 commits June 25, 2021 12:13

Update mirgecom/artificial_viscosity.py for lazy eval

d602975

Co-authored-by: Matthias Diener <matthias.diener@gmail.com>

Merge branch 'main' into artificial_viscosity

07b4ebe

Fix up calls to be like main - CV array container stuff

90b924e

Update to make_conserved - CV array container stuff

a259e51

Update per CV array container

2d42add

Placate flake8

a06062c

Update to latest APIs

bbe0281

thomasgibson removed a link to an issue Jul 17, 2021

Artificial viscosity: Laplacian versus physical approach #301

Open

MTCam mentioned this pull request Dec 14, 2021

Add AV to NS #373

Closed

MTCam closed this Jun 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Artificial viscosity#213

Artificial viscosity#213
w-hagen wants to merge 111 commits intoillinois-ceesd:mainfrom
w-hagen:artificial_viscosity

w-hagen commented Feb 3, 2021 •

edited

Loading

Uh oh!

MTCam commented May 6, 2021

Uh oh!

MTCam commented May 7, 2021

Uh oh!

Uh oh!

MTCam commented Jun 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

w-hagen commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Outstanding work needed before moving forward:

Uh oh!

MTCam commented May 6, 2021

Uh oh!

MTCam commented May 7, 2021

Uh oh!

Uh oh!

MTCam commented Jun 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

w-hagen commented Feb 3, 2021 •

edited

Loading