Conversation
inducer
reviewed
Jun 4, 2021
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! I think I agree with the sentiment here. Two drive-by comments along the way.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires/Targets #108 because of the
dt_utilsmodule. This PR cuts down the content ingrudge.opand modularizes the projection/interpolation and the reductions.This also removes
op.nodes/op.normal. The reason for this is due to the discussion here: illinois-ceesd/mirgecom#360 (comment). Overall, I pretty much agree that it makes much more sense to keepnodes/normalwith the discretization collection. Furthermore, we should not need to deprecate since Mirgecom (our only direct dependency) has yet to adopt the post-eager interface. So we have a unique opportunity here to make some decisions that won't cause widespread breakage.It also semi-revives
interpin anticipate of addressing issue #38 in a future PR (not this one). Alsointerpandprojectwas intentially split into two modules. The reason I did this is that we may want to expand the behavior for these functions as more and more features get added. I think it will be easier to maintain them if we keep them self-contained.