Conversation
This was
linked to
issues
Jun 4, 2021
thomasgibson
force-pushed
the
dist_reductions
branch
from
0b9565e to
e066671
Compare
thomasgibson
force-pushed
the
dist_reductions
branch
3 times, most recently
from
990eb29 to
f4ed6ce
Compare
thomasgibson
force-pushed
the
dist_reductions
branch
from
f4ed6ce to
0787d90
Compare
inducer
reviewed
Jun 5, 2021
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks, LGTM! Just one doc wrinkle.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Owner
|
Ready to un-draft? |
thomasgibson
force-pushed
the
dist_reductions
branch
from
f6e6a11 to
1edecc2
Compare
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #116 for the refactoring of the reductions.
This PR makes the nodal reductions MPI aware. Still need to add specific tests, but the examples seem to be working fine