-
Notifications
You must be signed in to change notification settings - Fork 13
Feature/missing hana tests #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
awildturtok
wants to merge
21
commits into
develop
Choose a base branch
from
feature/missing-hana-tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7041282
change filter tests to fit Hana schema
awildturtok 7fa0a10
More edits to tests so they work with HANA
awildturtok bd28e6f
first impl of Clickhouse connection
awildturtok 8c59703
first impl of Clickhouse connection
awildturtok 3d30f55
properly skip disabled tests
awildturtok 7f67a0f
fix env variable names
awildturtok 9439eed
All Clickhouse zeszs green!
awildturtok 330947b
enables and fixes even more tests for CH
awildturtok d276ebf
fixes pg test
awildturtok 6b15d52
fixes undefined behaviour
awildturtok 0e22746
some naming conflicts in tests
awildturtok 056e535
fixes form tests
awildturtok 2e62a57
Merge branch 'feature/CH-support' into feature/missing-hana-tests
awildturtok e6e3b77
adds injection for SelectConverters
awildturtok 59832b1
fixes all SQL tests
awildturtok 5eef162
Fixes access pattern for CBlock span calculation
awildturtok 39c2613
cleanup
awildturtok 49dd50d
Merge branch 'develop' into feature/missing-hana-tests
thoniTUB 32ba020
cleanup pg array handling
awildturtok adace58
Merge remote-tracking branch 'origin/feature/missing-hana-tests' into…
awildturtok a363838
fix pg and ch
awildturtok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -84,8 +84,8 @@ public QueryStep invertAggregatedIntervals(QueryStep baseStep, ConversionContext | |||||||||
| Field<Object> maxDateRange = DSL.function( | ||||||||||
| "daterange", | ||||||||||
| Object.class, | ||||||||||
| this.functionProvider.toDateField(this.functionProvider.getMinDateExpression()), | ||||||||||
| this.functionProvider.toDateField(this.functionProvider.getMaxDateExpression()), | ||||||||||
| (this.functionProvider.getMinDateExpression()), | ||||||||||
| (this.functionProvider.getMaxDateExpression()), | ||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| DSL.inline("[]") | ||||||||||
| ); | ||||||||||
|
|
||||||||||
|
|
||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das ist ein shortcircuit, in den logs ist es mir in den Tests aufgefallen für Formulare, dass das sonst eine Exception wirft. Ich würde mir das anschauen aber in einen separaten PR. Das ist schon länger ein Problem