Fix download dialogue bug in 4.4.0-rc1#1
Merged
Conversation
|
Thanks, @jamesmisson -- the code change looks reasonable to me. If @LanieOkorodudu has time to test and confirm that it works as expected on her end, I'd encourage her to approve and you to merge this when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug Lanie identified in 4.4.0-rc1 here: UniversalViewer#1761
The problem was that
openMediagoes off into a different way of rendering the images if there are choices on the manifest. This was skipping the use of the getExternalResources method on the extension, which fetches the resources for the download dialogue. So I've just moved this call to before the choice branch splits off.This fixes the bug, but the download dialogue is still limited to the first choice. A new issue will need to be opened to enable the download dialogue to offer the download for the currently visible choice.