Skip to content

Fix download dialogue bug in 4.4.0-rc1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesmisson merged 1 commit into from
May 21, 2026
Merged

Fix download dialogue bug in 4.4.0-rc1 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...tent-handlers/iiif/modules/uv-openseadragoncenterpanel-module/OpenSeadragonCenterPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,10 @@ export class OpenSeadragonCenterPanel extends CenterPanel<
this.$spinner.show();
}, 200);

// we need to do this before the choice branch even though the branch doesn't use images, because getExternalResources populates the resources needed for the download dialogue
let images: IExternalResourceData[] =
await this.extension.getExternalResources(resources);

// check for a choice on either of the displayed canvases if in 2-up view
const indices = this.extension.getPagedIndices();
const hasChoices = indices.some((index) => {
Expand Down Expand Up @@ -985,9 +989,6 @@ export class OpenSeadragonCenterPanel extends CenterPanel<
return;
}

let images: IExternalResourceData[] =
await this.extension.getExternalResources(resources);

const isGirder: boolean = this.extension.format === MediaType.GIRDER;

try {
Expand Down