fix(i18n): complete and improve German (de-DE) settings translations#8285
fix(i18n): complete and improve German (de-DE) settings translations#8285tobiasheinrichfaska wants to merge 5 commits into
Conversation
…ubDesc The apostrophe-s genitive is an anglicism; German proper-noun genitives take no apostrophe. Applies to both githubDesc entries in de-DE/settings.json. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Standardize second-person address to the capitalized forms (Du/Dich/Deine/ Deines/Deinem) for consistency across the German translation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR Review: fix(i18n): complete and improve German (de-DE) settings translationsSummaryThis PR completes the German (de-DE) translation of
Translation Quality AssessmentCompleteness: After this PR, the DE locale has exactly 307 keys matching the EN source 1:1 with zero missing and zero extra keys. Key ordering also matches the EN file precisely. Quality of new translations (spot checks):
Quality improvements to existing translations:
Consistency:
Issues FoundNone blocking. A few very minor observations (non-blocking):
RecommendationCan merge. The PR achieves full key parity with the EN source, all new translations are accurate and idiomatic, existing translations are meaningfully improved, JSON is valid, key order matches, and placeholders are preserved. No regressions introduced. Clean, well-structured contribution. |
Hyphenate/join compound nouns per German orthography (API-Server, API-Schlüssel, Server-Logs, Llamacpp-Updates/-Version, App-Daten, Serverkonfiguration, Fensterhintergrund, Proxy-SSL, …), fix "Pfadprefix"->"Pfadpräfix", and "RAM Total"->"Gesamter RAM". Addresses review feedback on janhq#8285. Each change reviewed and approved by the contributor (native German speaker) before commit; AI-assisted. Signed-off-by: Tobias Heinrich <tobias.a.w.heinrich@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Follow-up review (new commits detected since last review)
What changed since last review
New commit 1c0d57c (2026-06-07) addresses the compound-noun spelling concerns raised in our previous review:
- Hyphenated/joined compound nouns per German orthography: "Llamacpp Updates" → "Llamacpp-Updates", "Llamacpp Version" → "Llamacpp-Version", "App Version" → "App-Version", "App Daten" → "App-Daten", "App Logs" → "App-Protokolle", "Server Konfiguration" → "Serverkonfiguration", "Fenster Hintergrund" → "Fensterhintergrund", "Server Logs" → "Server-Protokolle", "Server Host" → "Server-Host", "Server Port" → "Server-Port", "API Schlüssel" → "API-Schlüssel", "API Prefix" → "API-Präfix", "API Endpunkt" → "API-Endpunkt", "Proxy SSL" → "Proxy-SSL", "Proxy Host SSL" → "Proxy-Host-SSL", "Proxy URL" → "Proxy-URL", "System Monitor" → "Systemmonitor", etc.
- Fixed "Pfadprefix" → "Pfadpräfix" (correct umlaut).
- Fixed "RAM Total" → "Gesamter RAM" (proper German word order).
- The commit also properly capitalizes remaining lowercase "deiner/deine" → "Deiner/Deine" instances that were missed in the earlier capitalization pass (in
httpsProxyandprivacysections).
All changes are linguistically correct. The contributor (native German speaker) reviewed and approved each change before commit.
Remaining observations (non-blocking)
general.releaseNotesDescstill uses "Sehe, was es Neues..." (imperative "Sehe" is non-standard; "Sieh" or "Siehe" is typical). This pre-dates this PR and is not a regression.- JSON remains valid, key order matches
en/settings.json, all 321 keys present, placeholders preserved.
Assessment
All concerns from the previous review have been addressed. The compound-noun corrections are thorough and consistent. The translation quality is high throughout.
Recommendation: can merge
|
Follow-up review — new commit(s) since last review. New commit reviewed
This commit addresses the compound-noun issues flagged in the previous review. The changes apply correct German orthography throughout:
All corrections are orthographically sound and follow standard Duden rules for compound formation with abbreviations and foreign words. Full PR status after all 4 commits
Minor pre-existing issues (not introduced by this PR)A few space-separated compounds exist in the base branch that this PR did not touch. These are out of scope but worth noting for a future cleanup:
These are not blockers for this PR since they were not part of the changed lines. VerdictThe new commit cleanly resolves the compound-spelling feedback from the prior review. The translation quality is high — natural German phrasing, consistent register, correct orthography, and complete key coverage. can merge |
Concede threshold -> "Ähnlichkeitsschwellenwert", topKDesc -> "Anzahl der zurückgegebenen Textpassagen." and runOnStartup -> "Autostart" to janhq#8256, so the overlapping de-DE strings match across both PRs and merge cleanly. Reviewed and approved by the contributor (native German speaker) before commit; AI-assisted. Signed-off-by: Tobias Heinrich <tobias.a.w.heinrich@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Follow-up Review — New Commit Since Last ReviewNew commit reviewed: What changedAlignment commit conceding three overlapping de-DE keys to PR #8256's wording:
Assessment
Previous feedbackAll compound-noun corrections from the initial review ( Recommendation: can merge |
|
There are more than one PRs with the same German translations. Please close duplicate ones and keep the one that is final. Thank you. |
Follow-up — Maintainer Feedback on Duplicate PRsAcknowledged @qnixsynapse's note. There are currently three overlapping German i18n PRs open:
PRs #8285, #8284, and #8289 each target a different locale file and are complementary, not duplicates of each other. #8256 has overlap with all three in the The contributors (@tobiasheinrichfaska and @Schwachinformatiker) have been coordinating in #8256 to resolve overlaps. From a code perspective, the cleanest path would be to pick one set of translations as the base and have the other contributor rebase. Recommendation: improve needed — The translations themselves are correct, but the PR authors should consolidate or clearly order their PRs to avoid merge conflicts. Waiting for contributor coordination to finalize. |
|
Thanks @qnixsynapse — this is already being handled, just paused on a teammate's availability. Quick summary: My three PRs aren't duplicates of each other — each touches a different locale file and they don't overlap: #8284 → The only real overlap is with #8256 (@Schwachinformatiker), on
The only thing we're waiting on is @Schwachinformatiker merging that align PR — he mentioned he'd be unresponsive for about a week (from Jun 11), so he should be back around now. Nothing needs closing; once he's merged #1 these will all combine cleanly. One open translation question for a maintainer when convenient: in #8289 I left an optional commit that unifies thread / chat / conversation → a single German word „Chat" (the stored entity is |
What
Completes and improves the German (de-DE) translation of
web-app/src/locales/de-DE/settings.json. Part of #8221.Changes
attachmentssection (30 keys), the notification-position and thread-scroll options ininterface,localApiServerdefault-model fields, andshortcutsentries.general,hardware,httpsProxy,localApiServer,dataFolder, and top-level keys) — e.g. „Keep application data" → „Anwendungsdaten behalten", „Release Notes" → „Versionshinweise".interface.title: „Erscheinungsbild" → „Benutzeroberfläche" (the section is Interface).interface.codeBlockTitle: „Code Block" → „Codeblock".Testing
JSON validated (parses; full key order matches
en/settings.json, 321 keys). No missing keys remain; the only values identical to English are intentional brand/technical terms.Note on screenshots
The contributing guide asks for a screenshot. This PR only edits a locale JSON file (no layout or logic change). As a free-time contributor on my personal device, I deliberately did not install and build the full app for security reasons, so I can't provide a running-app screenshot. Happy to coordinate if a maintainer wants to verify in-app.