fix(i18n): complete and clean up German (de-DE) common translations#8289
fix(i18n): complete and clean up German (de-DE) common translations#8289tobiasheinrichfaska wants to merge 4 commits into
Conversation
Add the 84 missing keys, translate the remaining English-leftover values, and fix existing translations: compound-noun spacing, old "daß"->"dass" spelling, stray formal "Sie" -> informal "Du", "Model"->"Modell" typos, a gender slip (KI -> "ihres"), trailing/leading spaces, and word order. Also standardize "Anbieter"->"Provider" and capitalize informal address. This commit keeps the original thread / chat / conversation wording distinct. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Render the three interchangeable English terms (thread, chat, conversation) with a single user-facing German word, "Chat", for a consistent UI. If these are meant to be distinct concepts, this commit can be dropped while keeping the previous one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR Review: fix(i18n): complete and clean up German (de-DE) common translationsSummary of ChangesThis PR updates
The PR is well-structured: 220 additions, 110 deletions, touching only the single translation file. The two-commit strategy is thoughtful -- it lets maintainers choose whether to accept the terminology unification or keep distinctions. Quality AssessmentPositives:
Values intentionally left as English are reasonable: Hardware, Hub, Name, Vision, Jan, Claude Code -- these are proper nouns or standard loanwords in German tech context. Issues Found1. Remaining formal "Sie" inconsistency (minor fix needed)
This is the only remaining instance of formal address in the entire file. Every other confirmation dialog uses informal
Note: this key ( 2.
3. Pre-existing typo not addressed (nit, not blocking)
4. Extra keys not in English source (informational) Two keys exist in de-DE but not in the English source:
These may be vestigial. Not blocking but worth noting. Recommendation: improve neededThe PR is high quality overall. The formal Once those are addressed, this is ready to merge. |
- Revert Provider->Anbieter (15 keys): every other locale localizes "provider" to its native word, and all other de-DE files use "Anbieter". - projects.deleteProjectDialog.description: formal "Sie" -> informal "Du" (the last formal holdout in the file). - mcpServers.enterCommand: "Kommando eingeben" -> "Befehl eingeben" (match the "command" -> "Befehl" change). - toast.editMessage.description: "des Models" -> "des Modells" (genitive typo). Addresses review feedback on janhq#8289. Each change reviewed and approved by the contributor (native German speaker) before commit; AI-assisted. Signed-off-by: Tobias Heinrich <tobias.a.w.heinrich@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Some evidence to back the terminology question (commit 2: unifying thread / chat / conversation to one German word, „Chat"). I checked the source, and these three appear to be the same logical concept surfaced under names borrowed from different layers:
So the English source itself uses three words for one thing. That's the rationale for commit 2 — German would read more consistently with a single term, and „Chat" matches the app's own primary action. That said, I checked the other locales and most keep the three words distinct (mirroring the English source) rather than unifying — so this really is your call:
Either is fine by me; commit 1 stands on its own regardless. Just let me know which you prefer. |
There was a problem hiding this comment.
Follow-up review (new commits detected since last review)
New Commit Since Last Review
e3dc61b — fix(i18n): use "Anbieter" + address review feedback (de-DE common)
This commit directly addresses all issues raised in the previous review:
| # | Previous Issue | Status |
|---|---|---|
| 1 | Formal "Sie" in projects.deleteProjectDialog.description |
Fixed — changed to informal "Bist Du sicher, dass Du dieses Projekt löschen möchtest?" |
| 2 | mcpServers.enterCommand inconsistency ("Kommando eingeben" vs "Befehl") |
Fixed — now reads "Befehl eingeben" |
| 3 | Genitive typo "des Models" in toast.editMessage.description |
Fixed — corrected to "des Modells" |
| 4 | Extra keys not in English source (informational) | Acknowledged — not blocking |
Additional Change: "Provider" Reverted to "Anbieter"
The new commit also reverts the Provider -> Anbieter terminology across 15 keys (e.g., modelProviders, addProvider, deleteProvider.*, hideProvider, showProvider). The author's rationale is sound: every other locale localizes "provider" to its native word, and all other de-DE translation files already use "Anbieter". This improves internal consistency across the German locale.
Assessment
All three actionable items from the previous review have been addressed. The Provider -> Anbieter revert is a good additional improvement. The file now has consistent informal address ("Du"), consistent terminology ("Anbieter", "Befehl", "Chat"), correct genitive forms, and all previously-missing keys translated.
No new issues found.
Recommendation: can merge
Follow-up Review — All Prior Feedback AddressedReviewing commit: Issues Resolved
Overall Quality
The contributor has engaged thoughtfully with feedback and provided code-level justification for design decisions. Recommendation: can merge |
|
Is this ready? |
|
Yes, ready for review. It's two commits:
I'm also coordinating with @Schwachinformatiker's #8256 (which adds the code-level i18n wiring + |
Concede this key to janhq#8256's wording (correct accusative) so the overlapping de-DE strings match across both PRs and merge cleanly. Reviewed and approved by the contributor (native German speaker) before commit; AI-assisted. Signed-off-by: Tobias Heinrich <tobias.a.w.heinrich@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Follow-up Review — New Commit Since Last ReviewNew commit reviewed: What changedSingle-key alignment commit: adopts PR #8256's wording for Assessment
Previous issuesAll three issues from the initial review remain resolved (formal Recommendation: can merge |
de-DE: complete + clean up
common.jsonThis adds the missing German keys, fixes existing translations (compound
spelling,
daß→dass, stray formal Sie,Model→Modell, a gender slip,trailing/leading spaces, word order), and standardizes terminology
(
Anbieter→Provider, capitalized informalDu). Part of #8221.All 84 previously-missing keys are now translated; the only values left equal to
English are intentional (proper nouns / identical-in-German: Hardware, Hub, Name,
Vision, Jan, etc.).
A terminology question — and why this PR has two commits:
The UI uses three English terms that look interchangeable to me — "thread",
"chat", and "conversation" (e.g.
newThread"New Thread" vsnewChat"New Chat",
conversationNotAvailable,projects.conversationsIn"Conversationsin …" next to
deleteAllThreads).To make this reviewable, the work is split into two commits:
keeping the original thread / chat / conversation wording distinct.
("Chat") for a consistent UI.
If "thread", "chat" and "conversation" are indeed the same concept, please take
both commits. If you intend a distinction I should preserve, just drop commit 2
and I'll keep commit 1 (or mirror whatever distinction you specify).
🤖 Generated with Claude Code