Marker link multiple pages with same name path fix#480
Open
Feldherren wants to merge 3 commits into
Open
Conversation
…uous, but gets full path if more than one file exists with same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When editing a marker, and linking a marker to a page, the dropdown/popup/modal correctly populates with all pages that have a name matching the entered text, including what folder the page is in if multiple copies of it exist. However, when a page that shares a name with another page in a different folder is selected, the resulting link to a page does not take this into account, so often a marker ends up linking to the wrong page.
This pull request fixes this behaviour.
Changes Proposed
Related Issues
Fixes #450
Checklist
Screenshots (if applicable)
Entering the name of a page that is used for multiple pages:

Full path in Note to Open field:

Popup title (and preview) of page where the full path had to be used:

Pages that don't share their name with another page don't need or use the full path:
