Skip to content

Marker link multiple pages with same name path fix #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Feldherren wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Marker link multiple pages with same name path fix #480

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d46e8c0
Added getLinkText helper function; gets just the page name if unambig…
Feldherren Jun 16, 2026
42865e5
Updated onChooseItem to use getLinkText helper.
Feldherren Jun 16, 2026
0ca0868
Updated selectSuggestion to use getLinkText helper.
Feldherren Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions src/modals/path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,30 +74,32 @@ export class PathSuggestionModal extends SuggestionModal<
return (<BlockCache>item).id;
}
}
onChooseItem(item: TFile | HeadingCache | BlockCache) {
private getLinkText(item: TFile | HeadingCache | BlockCache): string | null {
if (item instanceof TFile) {
this.text.setValue(item.basename);
return this.app.metadataCache.fileToLinktext(item, "", true);
}
if (!this.file) return null;
const linkText = this.app.metadataCache.fileToLinktext(this.file, "", true);
if (Object.prototype.hasOwnProperty.call(item, "heading")) {
return linkText + "#" + (<HeadingCache>item).heading;
}
if (Object.prototype.hasOwnProperty.call(item, "id")) {
return linkText + "^" + (<BlockCache>item).id;
}
return null;
}
onChooseItem(item: TFile | HeadingCache | BlockCache) {
const link = this.getLinkText(item);
if (!link) return;

if(item instanceof TFile) {
this.file = item;
this.cache = this.app.metadataCache.getFileCache(this.file);
} else if (Object.prototype.hasOwnProperty.call(item, "heading")) {
this.text.setValue(
this.file.basename + "#" + (<HeadingCache>item).heading
);
} else if (Object.prototype.hasOwnProperty.call(item, "id")) {
this.text.setValue(
this.file.basename + "^" + (<BlockCache>item).id
);
}
this.text.setValue(link);
}
selectSuggestion({ item }: FuzzyMatch<TFile | BlockCache | HeadingCache>) {
let link: string;
if (item instanceof TFile) {
link = item.basename;
} else if (Object.prototype.hasOwnProperty.call(item, "heading")) {
link = this.file.basename + "#" + (<HeadingCache>item).heading;
} else if (Object.prototype.hasOwnProperty.call(item, "id")) {
link = this.file.basename + "^" + (<BlockCache>item).id;
}
const link = this.getLinkText(item);

this.text.setValue(link);
this.onClose();
Expand Down