Fix GlobalSettings crash when JFrog CLI is not installed (XRAY-145646)#531
Merged
Jordanh1996 merged 4 commits intoJun 17, 2026
Merged
Conversation
After ide-plugins-common 2.4.x, JfrogCliDriver's second constructor arg is Log, not CLI path. Passing null caused NPE in isJfrogCliInstalled() on Windows where jf is often missing from PATH. Co-authored-by: Cursor <cursoragent@cursor.com>
attiasas
approved these changes
Jun 17, 2026
attiasas
left a comment
attiasas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I would try to add test that could replicate the issue you fixed
Simulates missing jf by pointing PATH at an empty directory so isJfrogCliInstalled() exercises the log path without mutating the host env. Co-authored-by: Cursor <cursoragent@cursor.com>
CommandExecutor merges System.getenv() and appends /usr/local/bin on Unix, so PATH isolation cannot reliably hide jf on macOS/ubuntu CI. Use mockConstruction instead and assert JfrogCliDriver receives a non-null Log. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes XRAY-145646 — IntelliJ plugin 2.9.0 fails to start on Windows with:
Root cause:
ide-plugins-common2.4.x (#525) changedJfrogCliDriver(Map, String path)toJfrogCliDriver(Map, Log).ServerConfigImpl.readConnectionDetailsFromJfrogCli()still passednullas the second argument — previously the CLI path, now theLog. Whenjfis not on PATH (common on Windows),isJfrogCliInstalled()callslog.error()and NPEs duringGlobalSettingsinit.Fix: Pass
new NullLog()instead ofnullwhen constructingJfrogCliDriver.Test plan
jfon PATH (broken 2.9.0 build)ConnectionDetailsFromCliTestupdated and passesMade with Cursor