Skip to content

Fix GlobalSettings crash when JFrog CLI is not installed (XRAY-145646) #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jordanh1996 merged 4 commits into from
Jun 17, 2026
Merged

Fix GlobalSettings crash when JFrog CLI is not installed (XRAY-145646) #531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1565e6d
Fix GlobalSettings NPE when JFrog CLI is not on PATH
Jordanh1996 Jun 16, 2026
7f6d5bf
Add regression test for CLI-not-on-PATH NPE (XRAY-145646)
Jordanh1996 Jun 17, 2026
a3b8f8c
Fix CLI-not-installed test for Unix CI runners
Jordanh1996 Jun 17, 2026
540a956
Shorten XRAY-145646 test docstring
Jordanh1996 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/jfrog/ide/idea/configuration/ServerConfigImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.jfrog.ide.idea.ui.configuration.ConnectionTimeoutSpinner;
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.lang3.Strings;
import org.jfrog.build.api.util.NullLog;
import org.jfrog.build.client.ProxyConfiguration;

import javax.annotation.CheckForNull;
Expand Down Expand Up @@ -498,7 +499,7 @@ public void readMissingConfFromEnv() {
* @return true if connection details loaded from JFrog CLI default server.
*/
public boolean readConnectionDetailsFromJfrogCli() throws IOException {
JfrogCliDriver driver = new JfrogCliDriver(new HashMap<>(EnvironmentUtil.getEnvironmentMap()), null);
JfrogCliDriver driver = new JfrogCliDriver(new HashMap<>(EnvironmentUtil.getEnvironmentMap()), new NullLog());
if (!driver.isJfrogCliInstalled()) {
return false;
}
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/jfrog/ide/idea/configuration/ConnectionDetailsFromCliTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.intellij.util.EnvironmentUtil;
import com.jfrog.ide.common.configuration.JfrogCliDriver;
import org.jfrog.build.api.util.NullLog;
import org.apache.commons.io.FileUtils;
import org.gradle.internal.impldep.org.junit.Assert;
import org.junit.Test;
Expand Down Expand Up @@ -71,7 +72,7 @@ public void testReadConnectionDetailsFromJfrogCli() throws IOException, Interrup

// Config JFrog CLI
if (cliParameters != null) {
JfrogCliDriver jfrogCliDriver = new JfrogCliDriver(envVars, null);
JfrogCliDriver jfrogCliDriver = new JfrogCliDriver(envVars, new NullLog());
jfrogCliDriver.runCommand(null, envVars, cliParameters, new ArrayList<>(), null, null);
}

Expand Down
Loading