Add support for parameter store authentication by stegojulia · Pull Request #7572 · kedacore/keda

stegojulia · 2026-03-26T10:01:02Z

Provide a description of what has been changed

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added (if applicable)
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6311

Relates to #840 and #1725

github-actions · 2026-03-26T10:01:15Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

snyk-io · 2026-03-26T10:01:19Z

⛔ Snyk checks have failed. 8 issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (8)
⛔	Open Source Security	0	3	1	4	8 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

rickbrouwer

Thanks for the PR 🙏🏼

Can you also add a changelog entry for this change?

rickbrouwer · 2026-03-29T07:54:57Z

+	// +kubebuilder:validation:MinItems=1
+	Parameters []AwsParameterStoreParameter `json:"parameters"`
+	// +optional
+	Credentials *AwsParameterStoreCredentials `json:"credentials"`


Should omitempty appear here too?

I believe omitempty isn't needed for pointers, same pattern is used for here

Could you include the line number in the reference, so I can check exactly which one you mean?

whoops sorry I thought I had, here it is https://github.com/stegojulia/keda/blob/3a66e4f91dbd340a4e06b262f5cd6396c325373b/apis/keda/v1alpha1/triggerauthentication_types.go#L409

Ah, check. I only know that part from the API convention for using that:

https://github.com/kubernetes/community/blob/main/contributors/devel/sig-architecture/api-conventions.md?plain=1#L841

rickbrouwer · 2026-03-29T07:55:05Z

+	// +optional
+	Credentials *AwsParameterStoreCredentials `json:"credentials"`
+	// +optional
+	PodIdentity *AuthPodIdentity `json:"podIdentity"`


Should omitempty appear here too?

I believe omitempty isn't needed for pointers, same pattern is used for here

rickbrouwer · 2026-03-29T07:59:53Z

+	Parameter string `json:"parameter"`
+	Name      string `json:"name"`
+	// +optional
+	WithDecryption *bool `json:"withDecryption,omitempty"`


Can you add here a comment to clarify what omitting WithDecryption (leaving it nil) means? Users likely need to set this to true to get the plaintext, right?

that's updated

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

github-actions · 2026-06-09T03:19:06Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

github-actions · 2026-06-16T03:20:38Z

This pull request has been automatically closed due to inactivity.

stegojulia · 2026-06-29T20:26:17Z

@rickbrouwer anything I can do to revive this PR?

rickbrouwer · 2026-06-30T07:52:44Z

@rickbrouwer anything I can do to revive this PR?

I have reopened the PR

stegojulia requested a review from a team as a code owner March 26, 2026 10:01

keda-automation requested a review from a team March 26, 2026 10:01

stegojulia mentioned this pull request Mar 26, 2026

update docs for parameter store support in trigger authentication kedacore/keda-docs#1725

Closed

1 task

rickbrouwer reviewed Mar 29, 2026

View reviewed changes

keda-automation requested a review from a team March 31, 2026 12:50

stegojulia force-pushed the paramstore branch 2 times, most recently from 29068c9 to 089c265 Compare March 31, 2026 13:07

stegojulia mentioned this pull request Apr 1, 2026

Add AWS Parameter Store support to TriggerAuthentication CRDs kedacore/charts#840

Open

4 tasks

rickbrouwer added merge-conflict This PR has a merge conflict and removed merge-conflict This PR has a merge conflict labels Apr 9, 2026

stegojulia force-pushed the paramstore branch 2 times, most recently from 548b0de to aca39e8 Compare April 9, 2026 13:00

stegojulia added 6 commits April 9, 2026 14:03

Add AWS Parameter Store support to TriggerAuthentication

5d9836b

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

Refactor AWS initialisation to avoid duplication

2517b5d

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

Explain withDecryption arg

461cdec

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

Update changelog

d581391

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

Make manifests

3f20162

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

Add AWS SSM SDK dependency and update vendor

d5f3e73

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

stegojulia force-pushed the paramstore branch from aca39e8 to 50b5736 Compare April 9, 2026 13:04

Clean up merge conflict markers and ensure SSM dependency is explicit

ce2edcc

Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>

stegojulia force-pushed the paramstore branch from 50b5736 to ce2edcc Compare April 9, 2026 13:06

github-actions Bot added the stale All issues that are marked as stale due to inactivity label Jun 9, 2026

github-actions Bot closed this Jun 16, 2026

rickbrouwer reopened this Jun 30, 2026

rickbrouwer added merge-conflict This PR has a merge conflict and removed stale All issues that are marked as stale due to inactivity labels Jun 30, 2026

Uh oh!

Conversation

stegojulia commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

snyk-io Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⛔ Snyk checks have failed. 8 issues have been found so far.

Uh oh!

rickbrouwer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

stegojulia commented Jun 29, 2026

Uh oh!

rickbrouwer commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stegojulia commented Mar 26, 2026 •

edited

Loading

snyk-io Bot commented Mar 26, 2026 •

edited

Loading

rickbrouwer left a comment •

edited

Loading